-
Notifications
You must be signed in to change notification settings - Fork 1.6k
📖 docs: migrate Quick Start to using Markdown admonitions #5459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
📖 docs: migrate Quick Start to using Markdown admonitions #5459
Conversation
Signed-off-by: Daniel Maslowski <info@orangecms.org>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: orangecms The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @orangecms. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @orangecms,
Thanks for taking a look at this.
However, I don’t think we should make this change.
The current structure provides a much better experience for readers and end users. When I’m reading documentation and I see a clear H1 title, I can immediately understand what the section is about and decide whether it’s relevant, or skip it if it isn’t.
With the proposed change (example below), the title/context becomes less obvious and it forces readers to scan more text just to figure out whether the section applies to them.
For example:
With the change: I have to read through more content to understand if it’s relevant.
With the current format: I can quickly skip sections I don’t care about (e.g., if I’m not using a specific feature like “Master channel” or I don’t need autocomplete).
Given that this would change the overall documentation structure/syntax and would require re-reviewing the rendered output across the docs to ensure it’s actually better for readers, I think we should only do it if there’s a strong, clearly justified benefit.
Comparing the two, the proposed layout is less reader-friendly: it reduces scannability and forces readers to read more before they can tell whether a section is relevant to their use case.
Therefore, IMO we should not move with this change.
/hold
Thanks!
|
Can we use TIP, Warning with the subtitles ? Could we solve the H1--H4 with class and js? |
No, they are just blocks with an extra icon, label and color.
I have already replied to this question in the other PR; maybe I don't understand the idea. |
|
Hi @orangecms, Please see: ( I added images based on the changes to clarify) My point is simple:
Because this is a rare case, keeping it clearly labeled helps users quickly decide whether to read or skip it. Does that make sense? |
Why? Tip means it's not necessarily relevant. There are 4 other kinds of admonitions. It's not only tip.
With the suggested format, I read the full note if the text in bold applies to me, same thing.
The 5 kinds of admonitions are clear labels? |
|
The last screenshot in #5459 (review) shows how the different admonitions help: |
That is not important at all. Unless you are looking to know what version are compatible,
Because the info ONLY matter is I am using the Master branch. |
|
Hi @orangecms, Thanks for raising this and taking a look. I’m OK with any solution as long as it preserves the outcome we need today and avoids regressions or new issues. For me, that means:
I think it would help if you could review the docs and try the tool yourself. The boxes are used in many places specifically as “only read this if it’s relevant to you,” and that pattern supports different personas and situations. For example, readers might be:
If we keep those personas in mind, the “optional but clearly labeled” boxes (with headers) are important to avoid overwhelming people while still providing the right info when needed. Thanks! |
This gets rid of redundancies from the additional headlines in the custom HTML, increases the density on the screen, and uses pure Markdown as defined by mdBook.
via #5457