docs: Consistency review on namespaced configs in chart readme#6146
docs: Consistency review on namespaced configs in chart readme#6146josemaia wants to merge 1 commit intokubernetes-sigs:masterfrom
Conversation
|
Welcome @josemaia! |
|
Hi @josemaia. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Pull Request Test Coverage Report for Build 21433770888Details
💛 - Coveralls |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
while i'm looking at this, maybe this is a question for @stevehipwell as chart owner or @jkroepke who originally made the table - does the support matrix list make sense to maintain here as is? a lot of sources are not covered (e.g. httproute, gateway...), which confused me when looking at the chart as my first contact with external-dns docs. It seems like a pain to maintain this list, especially if the plan is to move stuff out of tree. |
|
As I know, it was requested as comment on the implementing PR. |
What does it do ?
Review the "namespace-only" docs in the Helm chart for consistency.
Motivation
Saw a typo when installing the chart.
More