🐛 fix +listType marker not working on type alias fields#1359
Open
sivchari wants to merge 1 commit intokubernetes-sigs:mainfrom
Open
🐛 fix +listType marker not working on type alias fields#1359sivchari wants to merge 1 commit intokubernetes-sigs:mainfrom
sivchari wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
do-not-merge/invalid-commit-message
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sivchari The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/M
sivchari
force-pushed
the
fix-issue-988-listtype-type-alias
branch
from
06bfcda to
a39b281
Compare
k8s-ci-robot
removed
the
needs-rebase
sivchari
force-pushed
the
fix-issue-988-listtype-type-alias
branch
from
a39b281 to
639035d
Compare
k8s-ci-robot
added
the
needs-rebase
sivchari
force-pushed
the
fix-issue-988-listtype-type-alias
branch
from
639035d to
4d23c3a
Compare
k8s-ci-robot
removed
the
needs-rebase
Contributor
|
Code change looks good but we do need to fix the commit message please |
Include underlying type info (array/object) in schema for slice/map type aliases, allowing field-level markers like +listType to work. Signed-off-by: sivchari <[email protected]>
sivchari
force-pushed
the
fix-issue-988-listtype-type-alias
branch
from
4d23c3a to
98002b0
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
Member
Author
|
Sorry, fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include underlying type info (array/object) in schema for slice/map type aliases, allowing field-level markers like +listType to work.
Fixes #988