Skip to content

✨ feat(webhook): Add patch field for webhook customization#1339

Open
camilamacedo86 wants to merge 1 commit intokubernetes-sigs:mainfrom
camilamacedo86:namespaceSelector
Open

✨ feat(webhook): Add patch field for webhook customization#1339
camilamacedo86 wants to merge 1 commit intokubernetes-sigs:mainfrom
camilamacedo86:namespaceSelector

Conversation

@camilamacedo86
Copy link
Copy Markdown
Member

@camilamacedo86 camilamacedo86 commented Feb 15, 2026 •
edited
Loading

Enables filtering webhooks by namespace and object labels to solve the webhook bootstrap problem and support namespace-scoped operators. This markers will allow Kubebuilder abstracts the complexities.

Closes: #553 and #1338

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 15, 2026
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 15, 2026
@camilamacedo86 camilamacedo86 force-pushed the namespaceSelector branch 2 times, most recently from dad1fdb to 752154a Compare February 15, 2026 08:32
@camilamacedo86
Copy link
Copy Markdown
Member Author

camilamacedo86 commented Feb 15, 2026

@sbueringer @JoelSpeed WDYT?

JoelSpeed
JoelSpeed reviewed Feb 16, 2026
View reviewed changes
pkg/webhook/parser.go Outdated
// namespaceSelector=matchLabels~team=platform&matchExpressions~key=tier.operator=NotIn.values=system
//
// Operators: In, NotIn, Exists, DoesNotExist
// Syntax: ~ separates selector type, . separates fields, & combines selectors, | separates values
Copy link
Copy Markdown
Contributor

@JoelSpeed JoelSpeed Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we just allowed the user to write a JSON object representing a namespace selector, rather than coming up with some complex syntax?

Copy link
Copy Markdown
Member Author

@camilamacedo86 camilamacedo86 Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Good idea 👍

@alvaroaleman alvaroaleman mentioned this pull request Feb 19, 2026
Open
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 19, 2026
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 19, 2026
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 19, 2026
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 19, 2026
@camilamacedo86 camilamacedo86 force-pushed the namespaceSelector branch 3 times, most recently from a26f666 to de97a6a Compare February 19, 2026 08:06
@camilamacedo86
Copy link
Copy Markdown
Member Author

camilamacedo86 commented Feb 19, 2026

Hi @JoelSpeed and @sbueringer

Thank you for the help all addressed.

@JoelSpeed
Copy link
Copy Markdown
Contributor

JoelSpeed commented Feb 19, 2026

/lgtm
/assign @sbueringer

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 19, 2026

LGTM label has been added.

DetailsGit tree hash: 91384a821bc53e82b333bcbae4a51c6aca4e9d84

@programmer04 programmer04 mentioned this pull request Feb 24, 2026
Open
2 tasks
alvaroaleman
alvaroaleman reviewed Feb 25, 2026
View reviewed changes
pkg/webhook/parser.go Outdated
//
// // +kubebuilder:webhook:...,namespaceSelector=`{"matchLabels":{"webhook-enabled":"true"}}`
// // +kubebuilder:webhook:...,namespaceSelector=`{"matchExpressions":[{"key":"environment","operator":"In","values":["dev","staging","prod"]}]}`
NamespaceSelector string `marker:"namespaceSelector,optional"`
Copy link
Copy Markdown
Member

@alvaroaleman alvaroaleman Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you instead of these two just add a patch marker that contains a strategic merge patch that will be applied over the rest of the webhook so any current and future field can be adjusted that way?

Copy link
Copy Markdown
Member Author

@camilamacedo86 camilamacedo86 Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @alvaroaleman

Thank you for your input.
It is following your suggestion now.
Could you please give a look and let us know wdyt?
Could we get this one merged?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2026
@k8s-ci-robot k8s-ci-robot requested a review from sbueringer March 30, 2026 07:29
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 30, 2026

New changes are detected. LGTM label has been removed.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 30, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: camilamacedo86
Once this PR has been reviewed and has the lgtm label, please ask for approval from joelspeed. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86
feat(webhook): Add patch field for webhook customization
ecfe894 
Add a patch marker that applies strategic merge patches to webhooks, enabling configuration of namespaceSelector, objectSelector, and any other webhook field without requiring dedicated marker support.

Assisted-by: Cursor/Claude
@camilamacedo86 camilamacedo86 changed the title ✨ Add namespaceSelector and objectSelector to webhook markers ✨ feat(webhook): Add patch field for webhook customization Mar 30, 2026
@camilamacedo86
Copy link
Copy Markdown
Member Author

camilamacedo86 commented Apr 10, 2026

@sbueringer @JoelSpeed @alvaroaleman

All suggestions are addressed now.
Could we get this one merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vincepri vincepri Awaiting requested review from vincepri

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@sbueringer sbueringer Awaiting requested review from sbueringer

@alvaroaleman alvaroaleman Awaiting requested review from alvaroaleman

Assignees

@sbueringer sbueringer

@JoelSpeed JoelSpeed

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

controller-gen feature request: support objectSelector in webhook config generation

5 participants

@camilamacedo86 @JoelSpeed @k8s-ci-robot @alvaroaleman @sbueringer