✨ Add AnnotatedEventRecorderProvider interface#3509
✨ Add AnnotatedEventRecorderProvider interface#3509adri1197 wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
Add the missing AnnotatedEventf as a new interface AnnotatedEventRecorder under cluster, manager, and recorder provider
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: adri1197 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @adri1197! |
|
Hi @adri1197. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Adds support for creating event recorders that can attach custom annotations to events,
mirroring the
AnnotatedEventfcapability recently added toclient-go/tools/events(see kubernetes/kubernetes#138103).
This introduces a new
AnnotatedEventRecorderProviderinterface inpkg/recorderratherthan adding a method to the existing
Providerinterface, so this is a backwards-compatiblechange. Consumers can type-assert the manager/cluster to access the new functionality:
Changes: