Skip to content

🌱 Add minimalist EKS e2e quick test for PR sanity checks#5831

Open
intojhanurag wants to merge 7 commits intokubernetes-sigs:mainfrom
intojhanurag:test/eks-quick-pr-blocking
Open

🌱 Add minimalist EKS e2e quick test for PR sanity checks#5831
intojhanurag wants to merge 7 commits intokubernetes-sigs:mainfrom
intojhanurag:test/eks-quick-pr-blocking

Conversation

@intojhanurag
Copy link

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds a new minimalist EKS e2e test, that serves as a fast sanity check for PR validation. The test is designed to run on every PR to provide quick feedback on basic EKS functionality without requiring the full comprehensive test suite.

Key features:

  • Tagged with [PR-Blocking] and [smoke] labels for automatic inclusion in PR tests
  • Creates minimal EKS cluster (control plane + single managed node group)
  • Follows the same pattern as the existing unmanaged quick test

The test provides a balance between coverage and execution time, making it suitable for PR validation while minimizing AWS resource usage and costs.

Which issue(s) this PR fixes:
Fixes #5547

Special notes for your reviewer:

This implementation mirrors the structure of the unmanaged quick test (referenced in the issue). Key design decisions:

  1. Minimal cluster configuration: Uses only EKSControlPlaneOnlyFlavor + EKSManagedMachinePoolOnlyFlavor to reduce resource usage
  2. No scaling tests: Skips scaling validation to optimize execution time
  3. Reuses existing helpers: Leverages [ManagedClusterSpec](test/e2e/sui and MachinePoolSpec for consistency
  4. Resource management: Properly acquires/releases AWS quotas for parallel test execution

The test compiles successfully with make compile-e2e and is ready for integration into the CI/CD pipeline.

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests (N/A - this is an e2e test)
  • adds or updates e2e tests

Release note:

Add new minimalist EKS e2e quick test for PR sanity checks. The test validates basic EKS cluster creation and is tagged as [PR-Blocking] to run on every PR, providing fast feedback without requiring the full comprehensive test suite.

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 18, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign neolit123 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Jan 18, 2026
@k8s-ci-robot k8s-ci-robot requested review from AndiDog and nrb January 18, 2026 17:28
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 18, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @intojhanurag. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@intojhanurag intojhanurag changed the title Add minimalist EKS e2e quick test for PR sanity checks 🌱 Add minimalist EKS e2e quick test for PR sanity checks Jan 18, 2026
@intojhanurag
Copy link
Author

Hey @AndiDog , Do we need some aws credits before any contribution in this projects ?
Btw I am pretty much sure this PR is neat and clean , Please review if you have a moment .

@Ankitasw Ankitasw added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 20, 2026
@intojhanurag
Copy link
Author

Hey @Ankitasw , Is it my PR failing due to my PR issue ?
I checked the failing pull-cluster-api-provider-aws-e2e-blocking job. The error comes from Boskos not being able to allocate a host. All my code changes are unrelated to this failure.

@richardcase
Copy link
Member

/test pull-cluster-api-provider-aws-e2e-blocking

@intojhanurag
Copy link
Author

Hey @richardcase , All test has been passed 😀.
PTAL :)

@intojhanurag
Copy link
Author

Hey @AndiDog , I fixed the formatting issue

@intojhanurag
Copy link
Author

Hey @richardcase , I applied all your suggestion. I think above faliure is a flake . Love to iterate further if any suggestion .

ctx = context.TODO()
namespace = shared.SetupSpecNamespace(ctx, specName, e2eCtx)
clusterName = fmt.Sprintf("%s-%s", specName, util.RandomString(6))
requiredResources = &shared.TestResource{EC2Normal: 2 * e2eCtx.Settings.InstanceVCPU, IGW: 1, NGW: 1, VPC: 1}
Copy link
Author

@intojhanurag intojhanurag Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allocated 2x vCPUs for EKS control plane + managed node group (1 vCPU is insufficient for both components)
Tried to match with unmanaged quick-start pattern (see: unmanaged_CAPI_quick_test.go:51)
Any review appreciated :)

requiredResources = &shared.TestResource{EC2Normal: 2 * e2eCtx.Settings.InstanceVCPU, IGW: 1, NGW: 1, VPC: 1, ClassicLB: 1, EIP: 3, EventBridgeRules: 50}

@nrb
Copy link
Contributor

nrb commented Feb 16, 2026

/test pull-cluster-api-provider-aws-e2e-blocking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/feature Categorizes issue or PR as related to a new feature. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[E2E] Create EKS "Blocking" Test

6 participants