🌱 [KAL] Add integer kal linter#5830
🌱 [KAL] Add integer kal linter#5830kartikangiras wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
Signed-off-by: Kartik Angiras <angiraskartik@gmail.com>
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
|
Welcome @kartikangiras! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @kartikangiras. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/hold we shouldn't enable KAL linting for existing APIs, only enable this for API additions/changes. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| ocmClusterSpec.NetworkType = networkSpec.NetworkType | ||
| } | ||
|
|
||
| if controlPlaneSpec.DefaultMachinePoolSpec.VolumeSize >= 75 { |
There was a problem hiding this comment.
This is not right, Why removing this check ? I believe the 75 there cause volume size cannot be less than 75G
What type of PR is this?
/kind feature
What this PR does / why we need it:
Enable Integer Kal Linter
Closes: #5486
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist:
Release note: