Add Hugging Face organization slug helper under Allowed organization#2600
Add Hugging Face organization slug helper under Allowed organization#2600Taj010 wants to merge 2 commits intokubeflow:mainfrom
Conversation
Signed-off-by: Taj010 <[email protected]>
| 'Enter the name of the organization (for example, meta-llama) to sync models from. Hugging Face sources are limited to 1 organization to prevent performance issues related to loading large model sets.', | ||
| YAML: 'Upload or paste a YAML string.', | ||
| ORGANIZATION_SLUG: | ||
| 'Hugging Face organization’s name is case-sensitive and match the organization’s URL, which may differ from the displayed name. Use the organization’s URL slug found in the URL (e.g., Input: meta-llama from huggingface.co/meta-llama).', |
There was a problem hiding this comment.
| 'Hugging Face organization’s name is case-sensitive and match the organization’s URL, which may differ from the displayed name. Use the organization’s URL slug found in the URL (e.g., Input: meta-llama from huggingface.co/meta-llama).', | |
| 'Hugging Face organization’s name is case-sensitive and should match the organization’s URL, which may differ from the displayed name. Use the organization’s URL slug found in the URL (e.g., Input: meta-llama from huggingface.co/meta-llama).', |
grammatical correction
Signed-off-by: Taj010 <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| <ThemeAwareFormGroupWrapper | ||
| label={FORM_LABELS.ORGANIZATION} | ||
| fieldId="organization" | ||
| isRequired | ||
| descriptionTextNode={organizationDescriptionTxtNode} | ||
| helperTextNode={organizationHelperTxtNode} | ||
| > | ||
| {organizationInput} | ||
| </ThemeAwareFormGroupWrapper> | ||
| <FormHelperText> | ||
| <HelperText> | ||
| <HelperTextItem>{HELP_TEXT.ORGANIZATION_SLUG}</HelperTextItem> | ||
| </HelperText> | ||
| </FormHelperText> | ||
| </> |
There was a problem hiding this comment.
This PR will conflict with #2526 and will break the logic added there
| ORGANIZATION_SLUG: | ||
| 'Hugging Face organization’s name is case-sensitive and should match the organization’s URL, which may differ from the displayed name. Use the organization’s URL slug found in the URL (e.g., Input: meta-llama from huggingface.co/meta-llama).', |
There was a problem hiding this comment.
This will have the same problem from the previous comment, it should wait for the merge of #2526 and add following the const and logic there
|
@Philip-Carneiro: changing LGTM is restricted to collaborators DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3 participants
Description
This PR adds secondary helper text below the Allowed organization field on the Hugging Face catalog source form. This text will inform the administrator that the display name and organization name may differ and provide guidance on locating the correct organization name.
How Has This Been Tested?
This has been tested by navigating to
model-catalog-settings/add-sourceand ensuring the helper text is visible under the organization input field.Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes