fix(catalog): enforce non-root security context on catalog overlay initContainers#2568
Merged
google-oss-prow[bot] merged 1 commit intokubeflow:mainfrom Apr 10, 2026
Conversation
…itContainers Signed-off-by: manaswinidas <dasmanaswini10@gmail.com>
Raakshass
added a commit
to Raakshass/manifests
that referenced
this pull request
Apr 10, 2026
…ontainer Apply upstream fix from kubeflow/model-registry#2568: add runAsNonRoot and runAsUser: 65534 (nobody) to the perf-data-init container. The base deployment enforces runAsNonRoot: true at pod level, but the demo overlay init container uses busybox (UID 0), producing Init:CreateContainerConfigError. Re-add catalog deployment and wait blocks to model_registry_install.sh. Signed-off-by: Siddhant Jain <siddhantjainofficial26@gmail.com>
|
this matches the exact root cause i hit while debugging ci on kubeflow/manifests#3318. applied the same fix locally in 391883a3 to unblock our ci. once this merges and syncs downstream the manifests will be consistent. uid 65534 is the right call — both init containers only need read on configmap mounts and write on emptydir. |
Contributor
|
/lgtm |
Contributor
|
thanks for addressing this issue @manaswinidas good job! |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Al-Pragliola The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The demo and odh catalog overlay initContainers were missing
runAsNonRootandrunAsUserin their security contexts, causingInit:CreateContainerConfigErrorwhen the pod-levelrunAsNonRoot: trueis enforced by the base deployment (manifests/kustomize/options/catalog/base/deployment.yaml).Root Cause
The base catalog deployment sets
runAsNonRoot: trueat the pod level. Kubernetes enforces this on all containers in the pod, including initContainers. Both thedemoandodhoverlays patched in initContainers without specifying a non-root user:perf-data-initusesbusybox, which defaults to UID 0 (root)catalog-data-initusesquay.io/opendatahub/odh-model-metadata-collection, same missing constraintChanges
manifests/kustomize/options/catalog/overlays/demo/kustomization.yamlrunAsNonRoot: trueandrunAsUser: 65534toperf-data-initinitContainermanifests/kustomize/options/catalog/overlays/odh/kustomization.yamlrunAsNonRoot: trueandrunAsUser: 65534tocatalog-data-initinitContainermanifests/kustomize/options/catalog/overlays/odh/kustomization.yamlbehavior: add→behavior: create(the ConfigMapmodel-catalog-default-sourcesdoes not exist in the base, socreateis the correct value)UID 65534 (
nobody) is sufficient because both initContainers only read from configMap mounts and write toemptyDirvolumes.Context
Raised as a result of: kubeflow/manifests#3318 (comment)
The downstream manifests PR (kubeflow/manifests#3318) was blocked on this upstream issue — the demo overlay's
perf-data-initcontainer fails withInit:CreateContainerConfigErrordue to the UID 0 /runAsNonRootconflict.How Has This Been Tested?
runAsNonRoot: trueat the pod levelemptyDirvolumes, both of which work with UID 65534model-catalog-default-sourcesConfigMap does not exist in the base kustomization, makingcreatethe correctbehaviorvalue (notmergeorreplace)Merge criteria:
All the commits have been signed-off (To pass the
DCOcheck)The commits have meaningful messages
Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has manually tested the changes and verified that the changes work.
Code changes follow the kubeflow contribution guidelines.
For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label
ok-to-testhas been added to the PR.If you have UI changes