-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Enable model-registry with UI by default #3318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Raakshass
wants to merge
4
commits into
kubeflow:master
Choose a base branch
from
Raakshass:enable-model-registry-ui
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
eb96333
feat: enable model-registry with UI by default (rebase onto master)
Raakshass f9c6031
fix(ci): remove model-catalog demo overlay from CI install
Raakshass 391883a
fix(catalog): enforce non-root security context on demo overlay initC…
Raakshass 33bbce0
test(security): add unauthenticated access test and fix gateway port-…
Raakshass File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
132 changes: 132 additions & 0 deletions
132
applications/dashboard/overlays/istio/patches/configmap.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,132 @@ | ||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: dashboard-config | ||
| data: | ||
| settings: |- | ||
| { | ||
| "DASHBOARD_FORCE_IFRAME": true | ||
| } | ||
| links: |- | ||
| { | ||
| "menuLinks": [ | ||
| { | ||
| "icon": "book", | ||
| "link": "/jupyter/", | ||
| "text": "Notebooks", | ||
| "type": "item" | ||
| }, | ||
| { | ||
| "icon": "assessment", | ||
| "link": "/tensorboards/", | ||
| "text": "TensorBoards", | ||
| "type": "item" | ||
| }, | ||
| { | ||
| "icon": "device:storage", | ||
| "link": "/volumes/", | ||
| "text": "Volumes", | ||
| "type": "item" | ||
| }, | ||
| { | ||
| "icon": "kubeflow:katib", | ||
| "link": "/katib/", | ||
| "text": "Katib Experiments", | ||
| "type": "item" | ||
| }, | ||
| { | ||
| "type": "item", | ||
| "link": "/kserve-endpoints/", | ||
| "text": "KServe Endpoints", | ||
| "icon": "kubeflow:models" | ||
| }, | ||
| { | ||
| "icon": "assignment", | ||
| "link": "/model-registry/", | ||
| "text": "Model Registry", | ||
| "type": "item" | ||
| }, | ||
| { | ||
| "icon": "kubeflow:pipeline-centered", | ||
| "items": [ | ||
| { | ||
| "link": "/pipeline/#/pipelines", | ||
| "text": "Pipelines", | ||
| "type": "item" | ||
| }, | ||
| { | ||
| "link": "/pipeline/#/experiments", | ||
| "text": "Experiments", | ||
| "type": "item" | ||
| }, | ||
| { | ||
| "link": "/pipeline/#/runs", | ||
| "text": "Runs", | ||
| "type": "item" | ||
| }, | ||
| { | ||
| "link": "/pipeline/#/recurringruns", | ||
| "text": "Recurring Runs", | ||
| "type": "item" | ||
| }, | ||
| { | ||
| "link": "/pipeline/#/artifacts", | ||
| "text": "Artifacts", | ||
| "type": "item" | ||
| }, | ||
| { | ||
| "link": "/pipeline/#/executions", | ||
| "text": "Executions", | ||
| "type": "item" | ||
| } | ||
| ], | ||
| "text": "Pipelines", | ||
| "type": "section" | ||
| } | ||
| ], | ||
| "externalLinks": [], | ||
| "documentationItems": [ | ||
| { | ||
| "desc": "The Kubeflow website", | ||
| "link": "https://www.kubeflow.org/", | ||
| "text": "Kubeflow Website" | ||
| }, | ||
| { | ||
| "desc": "Documentation for Kubeflow Pipelines", | ||
| "link": "https://www.kubeflow.org/docs/components/pipelines/", | ||
| "text": "Kubeflow Pipelines Documentation" | ||
| }, | ||
| { | ||
| "desc": "Documentation for Kubeflow Notebooks", | ||
| "link": "https://www.kubeflow.org/docs/components/notebooks/", | ||
| "text": "Kubeflow Notebooks Documentation" | ||
| }, | ||
| { | ||
| "desc": "Documentation for Kubeflow Training Operator", | ||
| "link": "https://www.kubeflow.org/docs/components/training/", | ||
| "text": "Kubeflow Training Operator Documentation" | ||
| }, | ||
| { | ||
| "desc": "Documentation for Katib", | ||
| "link": "https://www.kubeflow.org/docs/components/katib/", | ||
| "text": "Katib Documentation" | ||
| } | ||
| ], | ||
| "quickLinks": [ | ||
| { | ||
| "desc": "Kubeflow Notebooks", | ||
| "link": "/jupyter/new", | ||
| "text": "Create a new Notebook" | ||
| }, | ||
| { | ||
| "desc": "Kubeflow Pipelines", | ||
| "link": "/pipeline/#/pipelines", | ||
| "text": "Upload a Pipeline" | ||
| }, | ||
| { | ||
| "desc": "Pipelines", | ||
| "link": "/pipeline/#/runs", | ||
| "text": "View Pipeline Runs" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| #!/bin/bash | ||
| set -euxo pipefail | ||
|
|
||
| # Install Model Registry server, UI, database, and catalog components | ||
| # This script can be used for local testing without GitHub Actions | ||
| # Usage: ./tests/model_registry_install.sh | ||
|
|
||
| echo "Installing Model Registry components..." | ||
|
|
||
| # Build and apply Model Registry server with database | ||
| echo "Deploying Model Registry server (with database)..." | ||
| kustomize build applications/model-registry/upstream/overlays/postgres \ | ||
| | kubectl apply -n kubeflow -f - | ||
|
|
||
| # Build and apply Model Registry Istio networking | ||
| echo "Deploying Model Registry Istio resources..." | ||
| kustomize build applications/model-registry/upstream/options/istio \ | ||
| | kubectl apply -n kubeflow -f - | ||
|
|
||
| # Build and apply Model Registry UI with Istio integration | ||
| echo "Deploying Model Registry UI..." | ||
| kustomize build applications/model-registry/upstream/options/ui/overlays/istio \ | ||
| | kubectl apply -n kubeflow -f - | ||
|
|
||
| # Build and apply Model Catalog (demo overlay) | ||
| echo "Deploying Model Catalog..." | ||
| kustomize build applications/model-registry/upstream/options/catalog/overlays/demo \ | ||
| | kubectl apply -n kubeflow -f - | ||
|
|
||
| # Wait for Model Registry database deployment | ||
| echo "Waiting for Model Registry database to become ready..." | ||
| if ! kubectl wait --for=condition=available -n kubeflow deployment/model-registry-db --timeout=120s; then | ||
| echo "ERROR: Model Registry database deployment failed" | ||
| kubectl get pods -n kubeflow -l app=model-registry-db | ||
| kubectl describe deployment/model-registry-db -n kubeflow | ||
| kubectl logs deployment/model-registry-db -n kubeflow | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Wait for Model Registry server deployment | ||
| echo "Waiting for Model Registry server to become ready..." | ||
| if ! kubectl wait --for=condition=available -n kubeflow deployment/model-registry-deployment --timeout=120s; then | ||
| echo "ERROR: Model Registry server deployment failed" | ||
| kubectl get pods -n kubeflow -l component=model-registry-server | ||
| kubectl describe deployment/model-registry-deployment -n kubeflow | ||
| kubectl logs deployment/model-registry-deployment -n kubeflow --all-containers | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Wait for Model Registry UI deployment | ||
| echo "Waiting for Model Registry UI to become ready..." | ||
| if ! kubectl wait --for=condition=available -n kubeflow deployment/model-registry-ui --timeout=120s; then | ||
| echo "ERROR: Model Registry UI deployment failed" | ||
| kubectl get pods -n kubeflow -l app=model-registry-ui | ||
| kubectl describe deployment/model-registry-ui -n kubeflow | ||
| kubectl logs deployment/model-registry-ui -n kubeflow --all-containers | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Wait for Model Catalog PostgreSQL StatefulSet | ||
| echo "Waiting for Model Catalog database to become ready..." | ||
| if ! kubectl wait --for=condition=ready -n kubeflow pod \ | ||
| -l app.kubernetes.io/name=postgres,app.kubernetes.io/part-of=model-catalog \ | ||
| --timeout=120s; then | ||
| echo "ERROR: Model Catalog database pod failed" | ||
| kubectl get pods -n kubeflow -l app.kubernetes.io/part-of=model-catalog | ||
| kubectl describe statefulset/model-catalog-postgres -n kubeflow | ||
| kubectl logs statefulset/model-catalog-postgres -n kubeflow | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Wait for Model Catalog server deployment | ||
| echo "Waiting for Model Catalog server to become ready..." | ||
| if ! kubectl wait --for=condition=available -n kubeflow deployment/model-catalog-server --timeout=120s; then | ||
| echo "ERROR: Model Catalog server deployment failed" | ||
| kubectl get pods -n kubeflow -l app.kubernetes.io/part-of=model-catalog | ||
| kubectl describe deployment/model-catalog-server -n kubeflow | ||
| kubectl logs deployment/model-catalog-server -n kubeflow --all-containers | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "Model Registry installation complete!" | ||
| kubectl get pods -n kubeflow -l component=model-registry-server | ||
| kubectl get pods -n kubeflow -l app=model-registry-ui | ||
| kubectl get pods -n kubeflow -l app.kubernetes.io/part-of=model-catalog |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.