Add type constants for init backup check#1641
Merged
kodiak-appscode[bot] merged 2 commits intomasterfrom Apr 9, 2026
Merged
Conversation
Signed-off-by: Anisur Rahman <anisur@appscode.com>
There was a problem hiding this comment.
Pull request overview
Adds new condition type/reason constants under apis/archiver/v1alpha1 to support checking whether an initial backup session completed successfully.
Changes:
- Introduces
TypeInitialBackupSucceededconstant. - Introduces success/failure reason constants for the initial backup completion check.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+93
to
+95
| TypeInitialBackupSucceeded = "InitialBackupSucceeded" | ||
| ReasonSuccessfullyCompletedInitialBackupSession = "SuccessfullyCompletedInitialBackup" | ||
| ReasonFailedToCompleteInitialBackupSession = "FailedToCompleteInitialBackup" |
There was a problem hiding this comment.
The Reason...InitialBackupSession constant names include Session, but their string values omit it ("SuccessfullyCompletedInitialBackup" / "FailedToCompleteInitialBackup"). This mismatch is easy to overlook and can lead to inconsistent condition reasons. Consider either updating the string values to include ...InitialBackupSession or renaming the constants to match the shorter values.
souravbiswassanto
added
the
automerge
souravbiswassanto
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.