Add separate api fields for load balancing specification#1618
Merged
souravbiswassanto merged 14 commits intomasterfrom Mar 29, 2026
Merged
Add separate api fields for load balancing specification#1618souravbiswassanto merged 14 commits intomasterfrom
souravbiswassanto merged 14 commits intomasterfrom
Conversation
souravbiswassanto
requested changes
Mar 5, 2026
147a61b to
cbde6f8
Compare
souravbiswassanto
requested changes
Mar 10, 2026
1dafc4b to
9c41fe6
Compare
Signed-off-by: HiranmoyChowdhury <hiranmoy@appscode.com>
Signed-off-by: HiranmoyChowdhury <hiranmoy@appscode.com>
Signed-off-by: HiranmoyChowdhury <hiranmoy@appscode.com>
Signed-off-by: HiranmoyChowdhury <hiranmoy@appscode.com>
Signed-off-by: HiranmoyChowdhury <hiranmoy@appscode.com>
Signed-off-by: HiranmoyChowdhury <hiranmoy@appscode.com>
Signed-off-by: HiranmoyChowdhury <hiranmoy@appscode.com>
Signed-off-by: HiranmoyChowdhury <hiranmoy@appscode.com>
Signed-off-by: HiranmoyChowdhury <hiranmoy@appscode.com>
Signed-off-by: HiranmoyChowdhury <hiranmoy@appscode.com>
f1600df to
92634a8
Compare
ArnobKumarSaha
requested changes
Mar 11, 2026
|
|
||
| type PgpoolUpdateBackendSpec struct { | ||
| // Sync specifies the list of backends that should be synced with the database. | ||
| Sync []v1alpha2.PgpoolLoadBalancingSpec `json:"sync,omitempty"` |
Member
There was a problem hiding this comment.
sync -> backends ?
type PgpoolCustomConfigurationSpec struct {
*ReconfigurationSpec json:",inline,omitempty"
Backends []v1alpha2.PgpoolLoadBalancingSpec json:"backends,omitempty"
}
Member
There was a problem hiding this comment.
basically like this?
spec:
configuration:
backends:
- hostName: demo.xyz
weight: 1
port: 5432
delete:
- reporting
- analytics
Member
Author
There was a problem hiding this comment.
not getting sync -> backends
Member
There was a problem hiding this comment.
basically like this?
spec: configuration: backends: - hostName: demo.xyz weight: 1 port: 5432 delete: - reporting - analytics
right.
Member
Author
There was a problem hiding this comment.
just wanna confirm if you want this...
so, this will be like:
spec:
configuration:
backends:
- hostName: demo.xyz
weight: 1
port: 5432
delete:
- reporting
- analytics
configSecret:
name: secretName
removeCustomConfig: true
just thought, configuration.delete is a bit unclear...
currently we are doing it like:
spec:
configuration:
backend:
sync:
- name: demo
weight: 2
- name: demo2
weight: 10
- name: STANDBY
weight: 8
delete:
- PRIMARY
removeCustomConfig: true
configSecret:
name: pp-custom-config
applyConfig:
pgpool.conf: |-
max_pool = 72
num_init_children = 9
Signed-off-by: HiranmoyChowdhury <hiranmoy@appscode.com>
souravbiswassanto
previously approved these changes
Mar 12, 2026
Signed-off-by: HiranmoyChowdhury <hiranmoy@appscode.com>
souravbiswassanto
approved these changes
Mar 13, 2026
ArnobKumarSaha
previously requested changes
Mar 13, 2026
|
|
||
| type PgpoolUpdateBackendSpec struct { | ||
| // Sync specifies the list of backends that should be synced with the database. | ||
| Sync []v1alpha2.PgpoolLoadBalancingSpec `json:"sync,omitempty"` |
Member
There was a problem hiding this comment.
basically like this?
spec: configuration: backends: - hostName: demo.xyz weight: 1 port: 5432 delete: - reporting - analytics
right.
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there is no way of getting weight other than this. and this requires only because of read replica in postgres(one may not have the same resource as others do)Signed-off-by: HiranmoyChowdhury hiranmoy@appscode.com