Open
Conversation
nyrahul
requested changes
Oct 21, 2022
Contributor
nyrahul
left a comment
There was a problem hiding this comment.
The policy rules are not useful. Please do not merge such rules. Looks like we are doing the same mistake that we have done before.
Comment on lines
+18
to
+26
| matchDirectories: | ||
| - dir: /var/lib/redis/ | ||
| recursive: true | ||
| - dir: /etc/redis/ | ||
| recursive: true | ||
| - dir: /var/log/redis/ | ||
| recursive: true | ||
| action: | ||
| Audit |
Contributor
There was a problem hiding this comment.
This policy is useless since it would generate barage of audit alerts.
Collaborator
|
@nyrahul we have updated all these policies before creating the v0.1.3 release. These PRs were merged into a single PR with appropriate modifications to make the release of v0.1.3. Sorry for not closing them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.