Cleans up Restore codegen and overall naming#19
Merged
Tomaz-Vieira merged 17 commits intokreshuklab:masterfrom Sep 3, 2025
Merged
Cleans up Restore codegen and overall naming#19Tomaz-Vieira merged 17 commits intokreshuklab:masterfrom
Restore codegen and overall naming#19Tomaz-Vieira merged 17 commits intokreshuklab:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Restoretrait would just invisibly guess that any type using#[derive(Restore)]was implementing the associated typeRestore::RawDataas a type in project_data.rs named{THE_TYPE_NAME}RawData. These patches make that type explicit now, via the#[restore(saved_data=path::to::your::SavedData)]attribute. It also changes the name of the associated type fromRawDatatoSavedDatato convey that it is the data that will be persisted to disk when saving a draft. All other attributes have been changed to the#[restore(...)]style, instead of#[restore_default]or#[restore_on_update].Notably, one place had to keep the
raw_dataterm (instead of moving tosaved_data: the keyapp_state_raw_data_versionthat tags the saved data. This is so that older saved model drafts can still be opened by this and newer versions of the app.