Open
Conversation
Contributor
|
Can you remove any changes to dist, yarn.lock, etc. and just include code changes? Also, can you please make this guarded by a global, like |
Contributor
|
I'm thinking we should still validate the major version no matter what. This may require some additional thought... The problem I want to avoid here is compatibility issues between parent and child, without a clear error message. This is a really easy situation to end up in if zoid adds a new parameter to the interface between parent and child... |
Author
|
The problem in reality is that parent site and children site may be
deployed separately and might be cached, also some changes are really minor
that owner is fully aware of what happening, however the error is a blocker
On Tue, Sep 3, 2019 at 01:20 Daniel Brain ***@***.***> wrote:
I'm thinking we should still validate the major version no matter what.
This may require some additional thought...
The problem I want to avoid here is compatibility issues between parent
and child, without a clear error message. This is a really easy situation
to end up in if zoid adds a new parameter to the interface between parent
and child...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#226?email_source=notifications&email_token=ABF6UMECCZFHS37EGEFVXP3QHVDPDA5CNFSM4HEIKIDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5WJHJI#issuecomment-527209381>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABF6UMCC2Q5IQAWSP5XI7R3QHVDPDANCNFSM4HEIKIDA>
.
--
Thangnt
|
eec1458 to
699be88
Compare
a6dbeec to
f8eeb3e
Compare
22cbfdf to
c890107
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.