Skip to content

Disable error throw#226

Open
thethanghn wants to merge 2 commits intokrakenjs:mainfrom
GoldenOwlAsia:disable-error-throw
Open

Disable error throw#226
thethanghn wants to merge 2 commits intokrakenjs:mainfrom
GoldenOwlAsia:disable-error-throw

Conversation

@thethanghn
Copy link
Copy Markdown

No description provided.

@bluepnume
Copy link
Copy Markdown
Contributor

Can you remove any changes to dist, yarn.lock, etc. and just include code changes?

Also, can you please make this guarded by a global, like if (__ZOID__.ALLOW_PARENT_CHILD_VERSION_MISMATCH)

@bluepnume
Copy link
Copy Markdown
Contributor

I'm thinking we should still validate the major version no matter what. This may require some additional thought...

The problem I want to avoid here is compatibility issues between parent and child, without a clear error message. This is a really easy situation to end up in if zoid adds a new parameter to the interface between parent and child...

@thethanghn
Copy link
Copy Markdown
Author

thethanghn commented Sep 3, 2019 via email

@bluepnume bluepnume force-pushed the master branch 3 times, most recently from eec1458 to 699be88 Compare September 24, 2019 07:36
@thethanghn thethanghn requested a review from a team as a code owner August 11, 2020 03:22
@bluepnume bluepnume force-pushed the master branch 5 times, most recently from a6dbeec to f8eeb3e Compare September 10, 2021 07:52
@bluepnume bluepnume force-pushed the master branch 2 times, most recently from 22cbfdf to c890107 Compare September 22, 2021 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants