Use standard package.json exports pattern#353
Open
wnayes wants to merge 2 commits intoklarna:alphafrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the alpha branch package.json to use
exportsto declare the different available exports. I was having a lot of trouble using the ESM code in the current alpha with how it is currently set up.This would be considered a breaking change, however it seems like the right direction to pursue for a future major release.
The first commit implements the proposed package exports changes.
The second commit updates the repository so that test code continues to compile. This was a little more involved.
Just putting this out here in case there is interest in taking the change upstream. I published this as @wnayes/electron-redux if anyone is interested.