Fix: Record TOC navigations in history (#1248)#1349
Fix: Record TOC navigations in history (#1248)#1349Jinash-Rouniyar wants to merge 2 commits intokiwix:mainfrom
Conversation
|
@Jinash-Rouniyar This is for #1248 (comment). Alt + Right is just forward navigation. This looks more like a bug of your own code. |
|
@kelson42 I have resolved the issues and TOC navigation is working as expected. I have now marked this pull request ready for review. Thanks. |
kelson42
force-pushed
the
fix-toc-history-1248
branch
from
957abc8 to
0b11cfd
Compare
kelson42
force-pushed
the
fix-toc-history-1248
branch
from
0b11cfd to
fbf9f2b
Compare
|
Hi @kelson42 , I noticed this PR is still open. Since you’ve force-pushed to the branch before, I wanted to check: do you still want me to rebase/update the PR if it is still useful, or would it be better to close it for now? |
|
@Jinash-Rouniyar I'm super late indeed. Very sorry, but we are preparing |
kelson42
force-pushed
the
fix-toc-history-1248
branch
2 times, most recently
from
aaa272e to
a04ea7c
Compare
kelson42
force-pushed
the
fix-toc-history-1248
branch
from
a04ea7c to
d236e53
Compare
kelson42
left a comment
kelson42
left a comment
There was a problem hiding this comment.
@veloman-yunkan @Jinash-Rouniyar After a very very long dealy to check this PR, I can only say that from a user perspective, it seems to do the job :) We can move forward with the code/technical review.
3 participants
Fixes #1248
Apologies for the previous pull request, which contained unrelated changes. This PR addresses issue #1248 by ensuring that TOC navigation actions are properly recorded in the in-page history, while still allowing JavaScript to handle scrolling. This prevents unnecessary page refreshes that would reset DOM states. The commit has been cleaned up to only include the relevant changes.
@kiwix/lieutenants Please review when available.