This repository was archived by the owner on Dec 27, 2023. It is now read-only.
Adding testing for deserialization of G1 and G2 points#39
Open
asanso wants to merge 7 commits intokilic:masterfrom
Open
Adding testing for deserialization of G1 and G2 points#39asanso wants to merge 7 commits intokilic:masterfrom
asanso wants to merge 7 commits intokilic:masterfrom
Conversation
Owner
|
Thanks :) |
AnomalRoil
reviewed
Jun 20, 2023
AnomalRoil
left a comment
AnomalRoil
left a comment
There was a problem hiding this comment.
Looks like you might want to remove the DS_Store file, but otherwise lgtm.
Thanks for the extra tests, more tests are always great since BLS isn't (yet) part of Wycheproof project :D
There was a problem hiding this comment.
I think this isn't meant to be committed. You might want to consider adding it to your global gitignore ;)
There was a problem hiding this comment.
@kilic It might be good to consider moving to a more recent Go version in the Go mod too, to get the dep pruning goodies from go 1.17 or higher 👼🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
taken from https://github.com/ethereum/bls12-381-tests/