Rotate per-instance logs by de-duping on file path#208
Open
SHA-2048 wants to merge 1 commit intokeymetrics:masterfrom
Open
Rotate per-instance logs by de-duping on file path#208SHA-2048 wants to merge 1 commit intokeymetrics:masterfrom
SHA-2048 wants to merge 1 commit intokeymetrics:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pm2-logrotate currently skips additional cluster instances by app name, so only one instance’s log paths are rotated and per-instance logs keep growing.
Fix
De-dupe by log file path instead of app name. This rotates every unique per-instance log while still avoiding duplicate work when logs are merged across instances.
Notes
Addresses #194.
Testing
Not run (module only).