Use generated tarballs instead of pack stdout#2
Open
iwizsophy wants to merge 2 commits intokekyo:developfrom
Open
Use generated tarballs instead of pack stdout#2iwizsophy wants to merge 2 commits intokekyo:developfrom
iwizsophy wants to merge 2 commits intokekyo:developfrom
Conversation
Author
|
Additional reproduction note: We reproduced this specifically with That makes stdout parsing fragile even if the final JSON payload itself is still produced. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm10 adjusted how lifecycle script output is displayed, andpackstdout can now include prefixed log lines such as>before the JSON result.Our previous implementation relied on parsing
packstdout to determine the generated tarball path, which made the flow fragile and caused JSON parsing failures when lifecycle output was mixed in.This change makes the pack flow rely on the actual generated artifacts instead of stdout parsing.
Changes
packstdout as the source of truth for the tarball pathpack-destinationafter a successfulpack*.tgzfile existsTesting
npm exec vitest run tests/cli-nullability.test.tsnpm exec vitest run tests/cli.test.ts