Skip to content

Manage multiple authors#147

Open
louckousse wants to merge 4 commits intokefranabg:masterfrom
louckousse:multi-authors
Open

Manage multiple authors#147
louckousse wants to merge 4 commits intokefranabg:masterfrom
louckousse:multi-authors

Conversation

@louckousse
Copy link

Fix #146

@codecov
Copy link

codecov bot commented Oct 5, 2019

Codecov Report

Merging #147 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #147   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          24     24           
  Lines         197    197           
  Branches       21     21           
=====================================
  Hits          197    197
Impacted Files Coverage Δ
src/questions/author-twitter.js 100% <ø> (ø) ⬆️
src/questions/author-github.js 100% <ø> (ø) ⬆️
src/questions/author-name.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32af6a2...797aa4b. Read the comment docs.

@patou
Copy link

patou commented Oct 9, 2019

And if there are not the same number of authors names and github names or twitter ?

Maybe, if there are multiple authors, ask github or twitter for each ?

@louckousse
Copy link
Author

person1,,person3 TADAM problem solved. The way questions are asked it's too complicated for me to loop on these.

@kefranabg
Copy link
Owner

Hey @louckousse (sorry for the delay) thanks for your work 💪 I'll try to improve the rendering part by moving the code from ejs to node (using inquirer transformer function), it will allow us to make this code testable 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the possibility to add multiple author during the questions

3 participants