fix: populate condition field when editing extraction rules#6185
Open
DragonBot00 wants to merge 1 commit intokeephq:mainfrom
Open
fix: populate condition field when editing extraction rules#6185DragonBot00 wants to merge 1 commit intokeephq:mainfrom
DragonBot00 wants to merge 1 commit intokeephq:mainfrom
Conversation
|
@DragonBot00 is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When creating an extraction rule with a condition (e.g. source.contains('grafana')), the condition is correctly saved and visible in the extraction rules overview. However, when clicking Edit on an existing rule, the condition field is empty — the previously saved condition is not pre-populated.
Root Cause
The AlertsRulesBuilder component initializes its internal CEL state from constructCELRules(selectedPreset), which returns an empty string when no preset is provided. Although the component accepts a defaultQuery prop, it was never wired into the state initialization, so the condition value passed from the edit form was silently ignored.
Additionally, the extraction edit form passes condition as defaultQuery, but condition is populated asynchronously via a useEffect. By the time condition is set, AlertsRulesBuilder has already mounted with an empty string.
Fix
Two changes were made:
�lerts-rules-builder.tsx: Wire the defaultQuery prop into the useCelState initialization so it is used as the fallback default when no preset CEL is available.
create-or-update-extraction-rule.tsx:
Testing
Fixes #5201