Validate --source so invalid values don’t raise KeyError#576
Open
dhunganapramod9 wants to merge 1 commit intokarpathy:masterfrom
Open
Validate --source so invalid values don’t raise KeyError#576dhunganapramod9 wants to merge 1 commit intokarpathy:masterfrom
dhunganapramod9 wants to merge 1 commit intokarpathy:masterfrom
Conversation
svlandeg
reviewed
Feb 28, 2026
Collaborator
svlandeg
left a comment
svlandeg
left a comment
There was a problem hiding this comment.
This is not a bad idea - are there similar places in the codebase that could be updated? Would be nice to do it all in one PR for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invalid --source (e.g. foo) caused a KeyError in load_model. Added choices=["sft", "rl"] so argparse rejects bad values with a clear error.