feat: conditionally hide messages in HTML and console based on table count and location settings#44
Merged
jvlara merged 1 commit intojvlara:mainfrom Apr 2, 2025
Merged
Conversation
jvlara
requested changes
Mar 14, 2025
Owner
jvlara
left a comment
jvlara
left a comment
There was a problem hiding this comment.
Thanks again for contributing 🚀. I've been quite busy lately, but better late than never jaja
…count and location settings * added logic to hide the message in HTML when ignore_table_count is 1 or less * added logic to hide the message in console when ignore_table_count is 1 or less * updated data processing to conditionally handle max_locations_per_table and ignore_table_count configurations * updated HTML and console output to reflect hidden messages based on configurations
jairosoto05
force-pushed
the
update_printer
branch
from
50cf5e9 to
e2f93b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces conditional logic to hide messages in HTML and console based on the configurations of
ignore_table_countandmax_locations_per_table.Changes made:
HTML updates:
The message about displaying tables with a minimum number of queries is now conditionally displayed based on the value of
ignore_table_count.Console updates:
Similarly, the message in the console about ignored tables is conditionally shown or hidden based on the value of
ignore_table_count.Data processing logic:
Updated the logic to handle
max_locations_per_tableconfigurations. Ifmax_locations_per_tableis set to 0, all locations will be shown, and the message related to the locations will be hidden.