-
Notifications
You must be signed in to change notification settings - Fork 114
fix: billing dynamic correction payouts #1276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🚫 Missing Linked IssueHi 👋 This pull request does not appear to be linked to any open issue yet. Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically. ✔️ How to fix this
Once linked, this check will pass automatically on your next push or when you re-run the workflow. Thanks for helping maintainers! 🙌 |
🚫 Missing Linked IssueHi 👋 This pull request does not appear to be linked to any open issue yet. Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically. ✔️ How to fix this
Once linked, this check will pass automatically on your next push or when you re-run the workflow. Thanks for helping maintainers! 🙌 |
kashif-m
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skip billing address screen / section if all fields are available
🚫 Missing Linked IssueHi 👋 This pull request does not appear to be linked to any open issue yet. Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically. ✔️ How to fix this
Once linked, this check will pass automatically on your next push or when you re-run the workflow. Thanks for helping maintainers! 🙌 |
1 similar comment
🚫 Missing Linked IssueHi 👋 This pull request does not appear to be linked to any open issue yet. Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically. ✔️ How to fix this
Once linked, this check will pass automatically on your next push or when you re-run the workflow. Thanks for helping maintainers! 🙌 |
🚫 Missing Linked IssueHi 👋 This pull request does not appear to be linked to any open issue yet. Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically. ✔️ How to fix this
Once linked, this check will pass automatically on your next push or when you re-run the workflow. Thanks for helping maintainers! 🙌 |
494a61e to
d68a51a
Compare
d68a51a to
3036057
Compare
Type of Change
Description
Fixed incorrect billing first name and last name population, along with related UI issues.
Issues ->
first_nameandlast_nameare set different values, but while making confirm calls both are getting same values.first_nameis set and other required fields too, andlast_nameisnullthen no billing field rendered. But still billing details header is appearing.How did you test it?
assume except
first_nameandlast_nameall fields are set.case 1:



first_name:Doest,last_name:Johncase 2: 'first_name







andlast_nameboth arenull`case 3a:




first_name:Doestislast_nameis null, interac (first_name and last_name is required)case 3b:

first_name:Doestislast_nameis null, sepa (first_name is required)case 4a:





first_name: null islast_name:John, interac (first_name and last_name is required)case 4b:

first_name: null islast_name:John, sepa (first_name is required)case 5:

first_name:Doest errtandlast_name:John wer, interac (first_name and last_name is required)case 6:


first_name: null andlast_name:John wer, interac (first_name and last_name is required)case 7:


first_name:Doest errtandlast_name: null, interac (first_name and last_name is required)Checklist
npm run re:build