Skip to content

Conversation

@aritro2002
Copy link
Contributor

@aritro2002 aritro2002 commented Oct 31, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Fixed incorrect billing first name and last name population, along with related UI issues.
Issues ->

  1. first_name and last_name are set different values, but while making confirm calls both are getting same values.
  2. if first_name is set and other required fields too, and last_name is null then no billing field rendered. But still billing details header is appearing.

How did you test it?

assume except first_name and last_name all fields are set.

case 1: first_name: Doest, last_name: John
image
image
image

case 2: 'first_nameandlast_nameboth arenull`
image
image
image
image
image
image
image

case 3a: first_name: Doest is last_name is null, interac (first_name and last_name is required)
image
image
image
image

case 3b: first_name: Doest is last_name is null, sepa (first_name is required)
image

case 4a: first_name: null is last_name : John, interac (first_name and last_name is required)
image
image
image
image
image

case 4b: first_name: null is last_name : John, sepa (first_name is required)
image

case 5: first_name: Doest errt and last_name: John wer, interac (first_name and last_name is required)
image

case 6: first_name: null and last_name: John wer, interac (first_name and last_name is required)
image
image

case 7: first_name: Doest errt and last_name: null, interac (first_name and last_name is required)
image
image

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@aritro2002 aritro2002 self-assigned this Oct 31, 2025
@aritro2002 aritro2002 added the Ready for Review PR with label Ready for Review should only be reviewed. label Oct 31, 2025
@semanticdiff-com
Copy link

Review changes with  SemanticDiff

@github-actions
Copy link
Contributor

🚫 Missing Linked Issue

Hi 👋 This pull request does not appear to be linked to any open issue yet.

Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically.

✔️ How to fix this

  • Add a keyword like Fixes #123 or Closes #456 to your PR description or a commit message.
  • Or link it manually using the "Linked issues" panel in the PR sidebar.

Tip: You can link multiple issues.
🚫 Note: If only one issue is linked, it must be open for this check to pass.

Once linked, this check will pass automatically on your next push or when you re-run the workflow.

Thanks for helping maintainers! 🙌

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

🚫 Missing Linked Issue

Hi 👋 This pull request does not appear to be linked to any open issue yet.

Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically.

✔️ How to fix this

  • Add a keyword like Fixes #123 or Closes #456 to your PR description or a commit message.
  • Or link it manually using the "Linked issues" panel in the PR sidebar.

Tip: You can link multiple issues.
🚫 Note: If only one issue is linked, it must be open for this check to pass.

Once linked, this check will pass automatically on your next push or when you re-run the workflow.

Thanks for helping maintainers! 🙌

Copy link
Contributor

@kashif-m kashif-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skip billing address screen / section if all fields are available

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

🚫 Missing Linked Issue

Hi 👋 This pull request does not appear to be linked to any open issue yet.

Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically.

✔️ How to fix this

  • Add a keyword like Fixes #123 or Closes #456 to your PR description or a commit message.
  • Or link it manually using the "Linked issues" panel in the PR sidebar.

Tip: You can link multiple issues.
🚫 Note: If only one issue is linked, it must be open for this check to pass.

Once linked, this check will pass automatically on your next push or when you re-run the workflow.

Thanks for helping maintainers! 🙌

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

🚫 Missing Linked Issue

Hi 👋 This pull request does not appear to be linked to any open issue yet.

Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically.

✔️ How to fix this

  • Add a keyword like Fixes #123 or Closes #456 to your PR description or a commit message.
  • Or link it manually using the "Linked issues" panel in the PR sidebar.

Tip: You can link multiple issues.
🚫 Note: If only one issue is linked, it must be open for this check to pass.

Once linked, this check will pass automatically on your next push or when you re-run the workflow.

Thanks for helping maintainers! 🙌

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

🚫 Missing Linked Issue

Hi 👋 This pull request does not appear to be linked to any open issue yet.

Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically.

✔️ How to fix this

  • Add a keyword like Fixes #123 or Closes #456 to your PR description or a commit message.
  • Or link it manually using the "Linked issues" panel in the PR sidebar.

Tip: You can link multiple issues.
🚫 Note: If only one issue is linked, it must be open for this check to pass.

Once linked, this check will pass automatically on your next push or when you re-run the workflow.

Thanks for helping maintainers! 🙌

sakksham7
sakksham7 previously approved these changes Nov 20, 2025
@aritro2002 aritro2002 added Development Blocked Not able to continue because of some blocker and removed Ready for Review PR with label Ready for Review should only be reviewed. labels Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development Blocked Not able to continue because of some blocker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: billing dynamic correction payouts

4 participants