refactor: use shared country/state list instead of S3 + local backups #1217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aritro2002
requested review from
AbhishekChorotiya,
ArushKapoorJuspay,
sakksham7 and
seekshiva
as code owners
|
Review changes with Changed Files
|
aritro2002
had a problem deploying
to
Testing
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR refactors the handling of country and state data by removing the S3 fetch logic and local backup variables, and instead directly using the shared code that already provides the complete list. This simplifies the implementation, reduces redundant code, and ensures a single source of truth for country and state information across the codebase.
How did you test it?
I tested it by removing the dynamic fields and adding custom values for billing.
Checklist
npm run re:build