feat(ui): Add inline volume split sliders#273
Merged
prajjwalkumar17 merged 4 commits intomainfrom Apr 29, 2026
Merged
Conversation
prajjwalkumar17
approved these changes
Apr 29, 2026
jagan-jaya
approved these changes
Apr 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the dashboard UI to support more inline editing flows, notably moving volume split allocation sliders into the per-gateway row and updating supporting UI/asset changes.
Changes:
- Inline volume split allocation sliders into the per-gateway “Split %” row (and remove the separate allocation panel).
- Update Analytics custom time-range UI to use an inline popover that can be dismissed via outside-click / Escape.
- Fix a missing React
useRefimport and regenerate committedwebsite/distbuild assets.
Reviewed changes
Copilot reviewed 4 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| website/src/components/pages/VolumeSplitPage.tsx | Moves allocation sliders inline into each gateway row; responsive layout adjustments. |
| website/src/components/pages/AnalyticsPage.tsx | Adds a dismissible popover for custom time range selection. |
| website/src/components/pages/PaymentAuditPage.tsx | Updates JSON inspector <pre> styling for improved readability. |
| website/src/components/pages/EuclidRulesPage.tsx | Adds missing useRef import to fix build. |
| website/dist/index.html | Updates hashed asset references after rebuild. |
| website/dist/decision-engine/index.html | Updates hashed asset references after rebuild. |
| website/dist/assets/index-cq4Fupgx.css | Removes old hashed CSS asset from build output. |
| website/dist/decision-engine/assets/index-cq4Fupgx.css | Removes old hashed CSS asset from build output. |
Comments suppressed due to low confidence (1)
website/src/components/pages/VolumeSplitPage.tsx:291
- The gateway name input has no associated label or aria-label. Since the column headers are hidden on small screens, this field (and the gateway ID field below) ends up without an accessible name and with unclear context on mobile. Add an explicit label (visible on mobile) or at least an aria-label tied to the row’s gateway label.
<input
value={g.gatewayName}
onChange={e => updateGateway(g.id, 'gatewayName', e.target.value)}
placeholder="e.g. stripe"
className="border border-slate-200 dark:border-[#222226] bg-transparent rounded-lg px-3 py-1.5 text-sm focus:outline-none focus:ring-1 focus:ring-brand-500"
/>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
292
to
297
| <input | ||
| value={g.gatewayId} | ||
| onChange={e => updateGateway(g.id, 'gatewayId', e.target.value)} | ||
| placeholder="optional gateway_id" | ||
| className="border border-slate-200 dark:border-[#222226] bg-transparent rounded-lg px-3 py-1.5 text-sm focus:outline-none focus:ring-1 focus:ring-brand-500" | ||
| /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useRefimport in the Euclid rules page so the frontend build from currentmainsucceeds.npm run build.Impact
This keeps gateway name, gateway ID, numeric split, and slider adjustment in one row, matching the requested side-by-side editing flow and reducing duplicate slider UI.
Validation
npm run buildcurl http://localhost:8080/healthhttp://localhost:5174/because port5173was already occupied.