fix: Checkout Diff check fixes #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubhodip900
reviewed
Dec 4, 2025
backend/domain_types/src/types.rs
Outdated
Comment on lines
2449
to
2450
| l2_l3_data: None, | ||
| authorized_amount: None, |
Collaborator
There was a problem hiding this comment.
in types.rs this fields are marked as none in all the places then why we are adding this fields ?
Shubhodip900
reviewed
Dec 9, 2025
backend/domain_types/src/types.rs
Outdated
Comment on lines
1378
to
1391
| .map(|descriptor| BillingDescriptor { | ||
| name: descriptor.name.clone(), | ||
| city: descriptor.city.clone(), | ||
| phone: descriptor.phone.clone(), | ||
| statement_descriptor: descriptor | ||
| .statement_descriptor | ||
| .clone() | ||
| .or_else(|| value.statement_descriptor_name.clone()), | ||
| statement_descriptor_suffix: descriptor | ||
| .statement_descriptor_suffix | ||
| .clone() | ||
| .or_else(|| value.statement_descriptor_suffix.clone()), | ||
| reference: descriptor.reference.clone(), | ||
| }) |
Collaborator
There was a problem hiding this comment.
As this code is repetitive use a from conversion.
Collaborator
|
Add diff check results for all the flows |
Shubhodip900
reviewed
Dec 9, 2025
| connector_tx_id | ||
| )) | ||
| } | ||
| impl< |
Collaborator
There was a problem hiding this comment.
Follow macro structure for RSync flow
Shubhodip900
previously approved these changes
Dec 10, 2025
AmitsinghTanwar007
previously approved these changes
Dec 10, 2025
Saptak88
dismissed stale reviews from Shubhodip900 and AmitsinghTanwar007
via
ab5dbfd
Shubhodip900
approved these changes
Dec 10, 2025
AmitsinghTanwar007
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Diff check fixes for connector checkout for the following flows
Motivation and Context
Additional Changes
How did you test it?