Skip to content

feat(connectors): [Peachpayments] Add Cards Flow #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Anurag-05-prog wants to merge 17 commits into
base: main
Choose a base branch
from
Open

feat(connectors): [Peachpayments] Add Cards Flow #188

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ff13bb7
feat(connectors): add peachpayments cards flow
Sep 21, 2025
669be83
Merge remote-tracking branch 'origin/main' into peachpayments
Sep 21, 2025
28eebec
Merge remote-tracking branch 'origin/main' into peachpayments
Sep 23, 2025
f66a0f6
fix: formatting error
Sep 23, 2025
d25d72d
add peachpayments test file
Sep 23, 2025
e8e6457
refactor: resolve comments
Sep 24, 2025
a586aa8
fix: expiry year length
Sep 24, 2025
ff7f039
Merge remote-tracking branch 'refs/remotes/origin/main' into peachpay…
Sep 24, 2025
e26c603
refactor: resolve coderabbit comments
Sep 24, 2025
1a21e57
Merge remote-tracking branch 'origin/main' into peachpayments
Sep 25, 2025
5d6ab24
Merge remote-tracking branch 'origin/main' into peachpayments
Sep 26, 2025
86afbac
Merge remote-tracking branch 'origin/main' into peachpayments
Sep 26, 2025
4a45f7d
Merge remote-tracking branch 'origin/main' into peachpayments
Sep 30, 2025
6f24ebd
refactor: resolve coderabbit comment
Oct 1, 2025
448e2a8
fix: resolve clippy error
Oct 1, 2025
7850134
Merge remote-tracking branch 'origin/main' into peachpayments
Oct 21, 2025
da3ae99
fix compilation errors
Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions backend/common_utils/src/consts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,10 +159,7 @@ impl Env {
|_| default_env,
|v| {
Self::deserialize(v.into_deserializer()).unwrap_or_else(|err: serde_json::Error| {
panic!(
"Invalid value found in environment variable {}: {}",
env_key, err
)
panic!("Invalid value found in environment variable {env_key}: {err}")
})
Comment on lines 169 to 171
Copy link

@coderabbitai coderabbitai bot Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix incorrect error type annotation causing compile error.

Self::deserialize(v.into_deserializer()) uses a serde::de::value::Error (via IntoDeserializer), not serde_json::Error. The explicit annotation mismatches the actual error type. Drop the type to let inference work.

-                Self::deserialize(v.into_deserializer()).unwrap_or_else(|err: serde_json::Error| {
-                    panic!("Invalid value found in environment variable {env_key}: {err}")
-                })
+                Self::deserialize(v.into_deserializer()).unwrap_or_else(|err| {
+                    panic!("Invalid value found in environment variable {env_key}: {err}")
+                })
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Self::deserialize(v.into_deserializer()).unwrap_or_else(|err: serde_json::Error| {
panic!(
"Invalid value found in environment variable {}: {}",
env_key, err
)
panic!("Invalid value found in environment variable {env_key}: {err}")
})
Self::deserialize(v.into_deserializer()).unwrap_or_else(|err| {
panic!("Invalid value found in environment variable {env_key}: {err}")
})
🤖 Prompt for AI Agents 
In backend/common_utils/src/consts.rs around lines 161 to 163, the closure in
unwrap_or_else currently annotates the error parameter as serde_json::Error
which is incorrect because Self::deserialize(v.into_deserializer()) yields a
serde::de::value::Error via IntoDeserializer; remove the explicit type
annotation from the closure parameter (i.e., use |err| or let inference pick the
type) so the compiler can infer the correct error type and the code compiles.

},
);
Expand Down
3 changes: 3 additions & 0 deletions backend/connector-integration/src/connectors.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,6 @@ pub use self::bluecode::Bluecode;

pub mod cryptopay;
pub use self::cryptopay::Cryptopay;

pub mod peachpayments;
pub use self::peachpayments::Peachpayments;
Loading
Loading