fix: Revamped the tools page sidebar #2095
Open
Kuzuri247 wants to merge 2 commits intojson-schema-org:mainfrom
Open
fix: Revamped the tools page sidebar #2095Kuzuri247 wants to merge 2 commits intojson-schema-org:mainfrom
Kuzuri247 wants to merge 2 commits intojson-schema-org:mainfrom
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2095 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 633 629 -4
Branches 196 196
=========================================
- Hits 633 629 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
Contributor
Author
Contributor
|
Hi @Kuzuri247 thanks for the effort! I'm actually assigned to this and already have a PR. We should probably stick with that one to avoid duplicates. |
Contributor
Author
|
I revamped the sidebar itself that's why mentioned the issue |
1 task
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR fixes the overlapping and weird positioning of the tools page sidebar.
Issue Number:
Closes #2086
Screenshots/videos:
https://drive.google.com/file/d/1rU8LBuN1n47wxtVasxRNTXYgtYrg6ygL/view?usp=sharing
If relevant, did you update the documentation?
Summary
This PR revamps the sidebar in tools section which changes the background, scroll area, layout and changes the sidebar to being sticky than at the top. This enhances the user experience and makes it easier to view as the dropdown now have only one selection window open.
Does this PR introduce a breaking change?
No.