Feature: CascadeUtilitiesMixin and HTML data attributes used in sample with Sal (Scroll Animation Library)#367
Open
haricot wants to merge 8 commits intojrief:masterfrom
Open
Feature: CascadeUtilitiesMixin and HTML data attributes used in sample with Sal (Scroll Animation Library)#367haricot wants to merge 8 commits intojrief:masterfrom
haricot wants to merge 8 commits intojrief:masterfrom
Conversation
update utils mixin attr_type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this, BootstrapUtilities give choice for property attr_type (css_classes or html_data_attrs)
Bootstrap4 is concerned with this with for example:
and for more generic:
GenericUtilities give same possibility as BootstrapUtilities but for generic library.
If it suits you, would you like it to be optional, like when the npm package sal.js is present?
The fonction
__new__is duplicated, we could remove it from BootstrapUtilities and use it like this, (this impacts the settings and should be branded deprecated for a while.) :demo:
