-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[5.4]Joomla.form.field xml code style #46809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 5.4-dev
Are you sure you want to change the base?
Conversation
Super minor PR just to remove some extra spaces and tabs code review only Signed-off-by: BrianTeeman <[email protected]>
|
I have tested this item ✅ successfully on 1681b8f Checked BEFORE and AFTER file and confirm the spacing is fixed AFTER PR applied. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46809. |
|
I tested the code and anlyze some issue in code as trailing whitespace in line 31 and 36 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46809. |
|
@exlemor my ide highlights this and i just happened to open the file to check something so might as well fix it when i see it |
Hi ompatwa000-svg, nice that you have noticed that, that is the purpose of Brian's PR, he detected those extra characters and his PR does something about that (removes them), once you have tested the PR and have confirmed/not confirmed that, you can press " View on Joomla! Issue Tracker " from the Joomla Patch Tester and validate/invalidate the test. |
|
I have tested this item ✅ successfully on 1681b8f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46809. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46809. |
Signed-off-by: BrianTeeman <[email protected]>
|
I realised that it was a copy paste error so checked and found some more instances |
Signed-off-by: BrianTeeman <[email protected]>
Super minor PR just to remove some extra spaces and tabs
code review only
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed