Skip to content

Conversation

@brianteeman
Copy link
Contributor

Super minor PR just to remove some extra spaces and tabs

code review only

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Super minor PR just to remove some extra spaces and tabs

code review only

Signed-off-by: BrianTeeman <[email protected]>
@exlemor
Copy link

exlemor commented Jan 31, 2026

I have tested this item ✅ successfully on 1681b8f

Hi @brianteeman, you have eagle eyes! (or possibly a great scanning tool) either way nice catch! :)

Checked BEFORE and AFTER file and confirm the spacing is fixed AFTER PR applied.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46809.

@ompatwa000-svg
Copy link

I tested the code and anlyze some issue in code as trailing whitespace in line 31 and 36


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46809.

@brianteeman
Copy link
Contributor Author

@exlemor my ide highlights this and i just happened to open the file to check something so might as well fix it when i see it

@exlemor
Copy link

exlemor commented Jan 31, 2026

I tested the code and anlyze some issue in code as trailing whitespace in line 31 and 36

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46809.

Hi ompatwa000-svg, nice that you have noticed that, that is the purpose of Brian's PR, he detected those extra characters and his PR does something about that (removes them), once you have tested the PR and have confirmed/not confirmed that, you can press " View on Joomla! Issue Tracker " from the Joomla Patch Tester and validate/invalidate the test.

@krishnagandhicode
Copy link

I have tested this item ✅ successfully on 1681b8f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46809.

@richard67 richard67 added the bug label Jan 31, 2026
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46809.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 31, 2026
@richard67 richard67 added this to the Joomla! 5.4.3 milestone Jan 31, 2026
@brianteeman brianteeman changed the title [5.4] radio.xml code style [5.4]Joomla.form.field.listl code style Feb 2, 2026
@brianteeman
Copy link
Contributor Author

I realised that it was a copy paste error so checked and found some more instances

@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 5.4.3 milestone Feb 2, 2026
@brianteeman brianteeman changed the title [5.4]Joomla.form.field.listl code style [5.4]Joomla.form.field xml code style Feb 2, 2026
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 2, 2026
Signed-off-by: BrianTeeman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants