-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[6.1] Display of translated translation title (workflow) #46806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
heelc29
wants to merge
14
commits into
joomla:6.1-dev
Choose a base branch
from
heelc29:6.1/workflow/translation-translated-title
base: 6.1-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[6.1] Display of translated translation title (workflow) #46806
heelc29
wants to merge
14
commits into
joomla:6.1-dev
from
heelc29:6.1/workflow/translation-translated-title
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Allon Moritz <[email protected]>
if all workflow plugins are not supported or disabled
Deprecated: explode(): Passing null to parameter joomla#2 ($string) of type string is deprecated
… 6.1/workflow/trans
Contributor
|
did you intend to include all the changes from your other pr with tests |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


This pull request builds on #46798, so that should be tested/merged first.
Summary of Changes
Since #35457 the transitions titles are translateable


For workflow and stage there is an extra field which shows the translated text and for transition it's missing.
This PRs adds the extra field with the translated value.
Testing Instructions
Edit an existing transition (you have to enable workflow integration)
Actual result BEFORE applying this Pull Request
only language key is there

Expected result AFTER applying this Pull Request
Translated value is displayed (here for example german)

Link to documentations
Please select: