-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[5.4] Email templates: make tags case insensitive #46787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 5.4-dev
Are you sure you want to change the base?
Conversation
|
please remove the unrelated ai generated code changes and just stick to fixing the issue |
|
Yeah, I didnt use AI for anything.. just saw a simplification since I was touching this method anyways. I'd be happy to contribute more fixes in the future, but not sure I like the tone here.. |
Hi @e4e5Ke2, Welcome! Thank you for your 1st contribution to Joomla! Please join us on Mattermost and get to know the Community! ( The AI comment wasn't meant negatively. Hope that you get to know Joomla coding standards, to exchange with you in Mattermost, to seeing you during PBF tomorrow and to your future participation! Cheers! ) |
|
I have tested this item ✅ successfully on 614c576 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46787. |
|
I have tested this item ✅ successfully on 614c576 Tag keys are normalized to uppercase (e.g., 'sitename' becomes 'SITENAME') This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46787. |
|
I have not tested this item. Before applying the patch, only uppercase email template tags like {SITENAME} worked. Patch works as expected. Test successful. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46787. |
|
I have tested this item ✅ successfully on 614c576 Before applying the patch, only uppercase email template tags like {SITENAME} worked. Patch works as expected. Test successful. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46787. |
|
I have successfully tested this item. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46787. |
…cessary implode" This reverts commit 614c576.
|
Removed the closures, functionality should be unchanged. |
Pull Request for Issue #46318
Summary of Changes
- Simplified some redundant code in said method with a closureTesting Instructions
Insert tags into any email templates, written in upper or lower case. They should now work regardless of case.
Actual result BEFORE applying this Pull Request
E.g. the tag {sitename} as part of a mail template did not work. Only in upper case the tag {SITENAME} gets replaced with a value.
Expected result AFTER applying this Pull Request
Now tags work regardless of being written in lower or upper case. E.g. {sitename} will now work the same way as {SITENAME}.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed