[6.1] Versions for Modules #46772

rdeutz · 2026-01-29T12:13:07Z

Summary of Changes

This is a base implementation for module versioning.

Testing Instructions

Apply patch
Make sure Database changes are executed, check if you have an entry for modules (id=14) in #__content_types
Enable Versioning in Module component configuration
Do changes on modules and switch versions, back and force
Try different module type also 3rd part modules

Actual result BEFORE applying this Pull Request

No Versions for modules available

Expected result AFTER applying this Pull Request

Versions for modules available

Link to documentations

Please select:

Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed

brianteeman · 2026-01-29T12:16:22Z

@rdeutz please follow the convention to out the joomla version in the PR title - it makes it easier to see the version the pr should be tested against

administrator/components/com_modules/config.xml

brianteeman · 2026-01-29T12:42:18Z

Please add the version note field

brianteeman · 2026-01-29T12:53:45Z

Please add Maximum Versions setting

brianteeman · 2026-01-29T12:53:57Z

all is looking good so far

administrator/components/com_admin/sql/updates/mysql/6.1.0-2026-01-29.sql

exlemor · 2026-01-29T13:50:05Z

For other testers, if you try to test this PR via Joomla Patch Tester even with the latest Nightly Build, you will get the error:
The file marked for modification does not exist: phpstan-baseline.neon

Use the Download package instead :)

rdeutz · 2026-01-29T14:55:21Z

@brianteeman version note and history limit added

brianteeman · 2026-01-29T15:11:56Z

Content versioning is available in both the site and admin so I would expect the same for module versioning. Currently its only enabled for the admin

brianteeman · 2026-01-29T15:25:20Z

Tested with core modules in the admin ui and module versioning is working as expected - cool stuff

rdeutz · 2026-01-29T15:37:45Z

Content versioning is available in both the site and admin so I would expect the same for module versioning. Currently its only enabled for the admin

I think it is a fair request. I have looked into it and a polite description how module edit is implemented in the frontend is: interesting. I would like to discuss this with the maintainers and don't start implementing it at this stage. I will come back with a decision.

vishalchincholi1 · 2026-01-30T06:35:26Z

Getting this error on locally while applying the patch
The file marked for modification does not exist: phpstan-baseline.neon

brianteeman · 2026-01-30T07:18:03Z

@vishalchincholi1

For other testers, if you try to test this PR via Joomla Patch Tester even with the latest Nightly Build, you will get the error:
The file marked for modification does not exist: phpstan-baseline.neon

Use the Download package instead :)

manojLondhe · 2026-01-30T07:18:08Z

I have tested this item 🔴 unsuccessfully on 473ab99

Getting error while applying patch as The file marked for modification does not exist: phpstan-baseline.neon

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.}

brianteeman · 2026-01-30T07:19:18Z

@manojLondhe

#46772 (comment)

This reverts commit 5c4fe50.

crimle · 2026-01-30T14:13:28Z

I have tested this item 🔴 unsuccessfully on 24ca80a

The button [Versions] appears correctly, but no versions are available after submitting several changes to the module. I tested modules of the type «Custom», «Tags popular» and «Articles».

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.}

brianteeman · 2026-01-30T14:16:45Z

@crimle did you run the sql before testing

crimle · 2026-01-30T14:25:44Z

@crimle did you run the sql before testing

No, I did not, sorry. There is no testing instruction that tells me to run SQL before testing. Apart from that, how could I possibly do this on my Test Server?

idefax · 2026-01-30T15:14:28Z

I have tested this successfully. I used core custom module and a 3rd party slider module.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.}

crimle · 2026-01-30T15:31:10Z

I have tested this item ✅ successfully on 24ca80a

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.}

crimle · 2026-01-30T15:32:04Z

After retesting I can confirm: it works!

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.}

dautrich · 2026-01-30T15:59:56Z

I have tested this item ✅ successfully on 24ca80a

Tested with a small module "Custom HTML" and with a third party module ("DWD Weather Warning" from Thomas Hunziker).

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.}

paternax · 2026-01-30T16:37:13Z

I have tested this item ✅ successfully on 24ca80a

The ‘Versions’ button is also displayed when versioning is deactivated. This is somewhat confusing, as it does not occur to you that versioning still needs to be activated.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.}

brianteeman · 2026-01-30T16:42:33Z

@paternax that is not the intended behaviour. the versions button should not be present if versions is not enabled. can you please retest. Otherwise you should change your success to a failed test

dautrich · 2026-01-30T17:15:36Z

@paternax @brianteeman
On my test site, the "Versions" button is only displayed, when versioning is enabled in the configuration. I just tested this again.

brianteeman · 2026-01-30T18:30:01Z

@dautrich thats my experience as well which is why I asked for a retest - maybe there is some scenario we didnt consider causing the button to be permanently visible

exlemor · 2026-01-30T21:06:59Z

I have tested this item ✅ successfully on 24ca80a

I have successfully tested this with Olivier watching during PBF 2026 Friday... @rdeutz - please validate if this passes based on below:
Tested this on 2 installations, same results!

Applying the PR, did NOT update the SQL for me, had to add SQL code into database via phpMyAdmin
With core module and 3rd party extension changing 5-6 fields in multiples tabs including playing with Associations on a multi-lingual site, the PR does what it claims and shows/restores previous versions of the Module

HOWEVER, and this may be outside of scope or on purpose, the Permissions Tab values/data does NOT get restored (i.e. if you Allow, Deny or Inherit) the values stay the same even after a or multiple restores

Personally impressed that Versioning worked even with complex setup + multilingual associations = 🥰 😍

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.}

idefax · 2026-01-31T08:26:52Z

I have tested this item ✅ successfully on 24ca80a

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.}

gioacchino54 · 2026-01-31T10:42:05Z

I applied the patch, but id=14 is not reported in the database.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.}

dautrich · 2026-01-31T10:44:24Z

@gioacchino54
As mentioned in the testing instructions, you need to apply the SQL script from the patch manually, i.e. via phpMyAdmin.

dusries · 2026-01-31T11:03:30Z

I was able to test this successfully.
However, I did not see any (id=14) in #__content_types in the database.
Not even after clearing the browser cache.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.}

dautrich · 2026-01-31T11:06:06Z

@dusries
As mentioned in the testing instructions, you need to apply the SQL script from the patch manually, i.e. via phpMyAdmin.

Razzo1987 · 2026-01-31T11:14:23Z

I have tested this item ✅ successfully on 24ca80a

Tested with multiple modules.

eg:

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.}

gioacchino54 · 2026-01-31T11:26:59Z

I have tested this item ✅ successfully on 24ca80a

Successfully applied

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.}

gioacchino54 · 2026-01-31T11:29:00Z

@dautrich Sorry, I didn't see that.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.}

gioacchino54 · 2026-01-31T11:30:40Z

I have tested this item ✅ successfully on 24ca80a

Successfully applied

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.}

gioacchino54 · 2026-01-31T11:32:09Z

Tested correctly and I can see the module versions.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.}

rdeutz · 2026-01-31T14:09:13Z

I reapplied the PHP Stan fix to get the testing green, I would say we have enough manual tests and it is save to merge.

rdeutz · 2026-01-31T14:10:58Z

Thanks to all the testers, RTC.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.}

brianteeman · 2026-01-31T14:19:54Z

@rdeutz are you leaving front end versioning to a new issue?

rdeutz · 2026-01-31T16:20:22Z

@rdeutz are you leaving front end versioning to a new issue?

Kind of, I will wait till a decision is made and then look what we can do.

torstenhoppe · 2026-02-02T18:37:05Z

I have tested this item ✅ successfully on 0bdb14b

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46772.}

RobertDeutz added 3 commits January 29, 2026 13:02

Database changes

a78a3ac

add config option

4c546ad

enable version for modules

73ba798

joomla-cms-bot added the PR-6.1-dev label Jan 29, 2026

brianteeman reviewed Jan 29, 2026

View reviewed changes

administrator/components/com_modules/config.xml Outdated Show resolved Hide resolved

rdeutz changed the title ~~Feature/module versions~~ [6.1] Feature/module versions Jan 29, 2026

RobertDeutz added 2 commits January 29, 2026 13:30

PHP Stan Fix

5c4fe50

indentation

c457b4d

rdeutz added the Feature label Jan 29, 2026

rdeutz changed the title ~~[6.1] Feature/module versions~~ [6.1] Versions for Modules Jan 29, 2026

richard67 reviewed Jan 29, 2026

View reviewed changes

administrator/components/com_admin/sql/updates/mysql/6.1.0-2026-01-29.sql Show resolved Hide resolved

tecpromotion added the PBF Pizza, Bugs and Fun label Jan 29, 2026

RobertDeutz and others added 3 commits January 29, 2026 15:53

remove version note for admin modules when version is disabled

ffd9d7f

add version note and history limit

8034384

Merge branch '6.1-dev' into feature/module-versions

66b3bb6

Merge branch '6.1-dev' into feature/module-versions

473ab99

Revert "PHP Stan Fix"

24ca80a

This reverts commit 5c4fe50.

Apply Stan fix after enough manual test

6f66060

Merge branch '6.1-dev' into feature/module-versions

0bdb14b

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 31, 2026

Uh oh!

[6.1] Versions for Modules #46772

Are you sure you want to change the base?

[6.1] Versions for Modules #46772

Uh oh!

Conversation

rdeutz commented Jan 29, 2026

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Uh oh!

brianteeman commented Jan 29, 2026

Uh oh!

Uh oh!

brianteeman commented Jan 29, 2026

Uh oh!

brianteeman commented Jan 29, 2026

Uh oh!

brianteeman commented Jan 29, 2026

Uh oh!

Uh oh!

exlemor commented Jan 29, 2026

Uh oh!

rdeutz commented Jan 29, 2026

Uh oh!

brianteeman commented Jan 29, 2026

Uh oh!

brianteeman commented Jan 29, 2026

Uh oh!

rdeutz commented Jan 29, 2026

Uh oh!

vishalchincholi1 commented Jan 30, 2026

Uh oh!

brianteeman commented Jan 30, 2026

Uh oh!

manojLondhe commented Jan 30, 2026

Uh oh!

brianteeman commented Jan 30, 2026

Uh oh!

crimle commented Jan 30, 2026

Uh oh!

brianteeman commented Jan 30, 2026

Uh oh!

crimle commented Jan 30, 2026

Uh oh!

idefax commented Jan 30, 2026

Uh oh!

crimle commented Jan 30, 2026

Uh oh!

crimle commented Jan 30, 2026

Uh oh!

dautrich commented Jan 30, 2026

Uh oh!

paternax commented Jan 30, 2026

Uh oh!

brianteeman commented Jan 30, 2026

Uh oh!

dautrich commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brianteeman commented Jan 30, 2026

Uh oh!

exlemor commented Jan 30, 2026

Uh oh!

idefax commented Jan 31, 2026

Uh oh!

gioacchino54 commented Jan 31, 2026

Uh oh!

dautrich commented Jan 31, 2026

Uh oh!

dusries commented Jan 31, 2026

Uh oh!

dautrich commented Jan 31, 2026

Uh oh!

Razzo1987 commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gioacchino54 commented Jan 31, 2026

dautrich commented Jan 30, 2026 •

edited

Loading

Razzo1987 commented Jan 31, 2026 •

edited

Loading