-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[6.1] Echo result of onAfterDisplay event #46771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 6.1-dev
Are you sure you want to change the base?
Conversation
|
Conflict with #46770 as far as I see it. |
|
I will rebase the commit once the other PR is accepted. |
a339286 to
26d40d0
Compare
|
It's resolved now 👍 |
|
I have tested this item ✅ successfully on 26d40d0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46771. |
|
I have tested this item ✅ successfully on d22b0ac This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46771. |
|
Please note that it was rejected 3 years ago: #41506 |
d22b0ac to
089fb6a
Compare
|
@Denitz Thanks, we could also reopen your PR. The import thing to note is that there is no way to modify the output and store that modification in the cache. |
|
No need to open my PR, let's use yours - the fresh one. |
|
I have tested this item ✅ successfully on 089fb6a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46771. |
Summary of Changes
Currently it's not possible to manipulate the result within the
onAfterDisplayevent of theHtmlViewclass.The event was introduced here: e8dfbb4
This change makes it possible to change the output of a template script and have the changed output cached with Joomla's progressive caching enabled.
Testing Instructions
No test instructions. No views should be affected.
Actual result BEFORE applying this Pull Request
This change should not cause any change in Joomla's behavior.
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed