[5.4] Exclude Symfony HTTP client test folders from release packages

[sathwikre]

Fixes #46764

The Symfony HttpClient packages currently include Test directories in Joomla release archives. These folders contain test-only classes and are not required in production distributions.

This change updates the build system to exclude:

• libraries/vendor/symfony/http-client-contracts/Test
• libraries/vendor/symfony/http-client/Test

As a result, release packages no longer ship unnecessary test files, reducing package size and avoiding unintended exposure of test code.

[brianteeman]

This is not the correct way to do it. see this example

https://github.com/joomla/joomla-cms/blob/5.4-dev/build/build.php#L129-L130

[sathwikre]

Thanks for the guidance. I’ve updated the build cleanup rules to follow the existing pattern as suggested.

[brianteeman]

I think you will find it better to make the change here

https://github.com/joomla/joomla-cms/blob/5.4-dev/build/build.php#L169-L173

run_and_check('rm -rf libraries/vendor/symfony/*/Test');

That way it will also pick up libraries\vendor\symfony\service-contracts\Test

[sathwikre]

Thanks for the suggestion. I’ve updated the build cleanup to use a wildcard removal for Symfony Test directories, following the existing cleanup pattern.

[sathwikre]

Thanks for the guidance. I’ve updated the cleanup section so the Symfony */Test directories are removed before the */Tests rule, and I’ve removed the extra comment as suggested.
This now follows the existing ordering pattern and also correctly handles additional Symfony test folders like service-contracts/Test.

Please let me know if anything else needs adjusting.

[sathwikre]

I’ve applied your suggested change and committed the updated ordering. Thanks for the review!

[brianteeman]

sorry I must have made a mistake - please put the tab back and remove the empty line

Then it should be complete

[sathwikre]

Fixed formatting as requested (tab restored, empty line removed).
Ready for final review. Thanks!

[brianteeman]

I have tested this item ✅ successfully on 2798e8e

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46765.}

[sathwikre]

Thanks for testing and confirming. Ready for merge when convenient.

[465645]

I have tested this item ✅ successfully on 2798e8e

I have tested this PR successfully
Joomla Version: 5.4.3-dev
PHP Version: 8.2.12
OS: Windows 11
Environment: XAMPP
Test Results
All Test directories were properly identified
The wildcard pattern approach works correctly
No errors during testing

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46765.}

[ompatwa000-svg]

I have tested this item ✅ successfully on 2798e8e

According to I study and anlyze the code according to that i will say given code is correct and i will propose that if you can add some comands in clean_checkout function so that it can remove libraries/vendor/symfony/http-client-contracts/Test.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46765.}

[sathwikre]

Thanks for testing and the suggestion 👍

The directory libraries/vendor/symfony/http-client-contracts/Test is already covered by the existing wildcard cleanup:

libraries/vendor/symfony/*/Test

This was added intentionally to handle current and future Symfony packages consistently, so no additional command should be required.

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46765.}

[sathwikre]

Thanks everyone. Marking as ready for merge.

[muhme]

✅ Final test before merge with JBT

• Checked update and full package ZIPs from nighlty build contains directories Test with files and subdirectories:

  ./libraries/vendor/symfony/validator/Test
  ./libraries/vendor/symfony/translation-contracts/Test
  ./libraries/vendor/symfony/var-dumper/Test
  ./libraries/vendor/symfony/http-client/Test
  ./libraries/vendor/symfony/service-contracts/Test
  ./libraries/vendor/symfony/http-client-contracts/Test
  

• Applied PR with Patch Tester
• php build/build.php --exclude-gzip --exclude-zstd --remote=HEAD
• Verified that full and update ZIP packages no longer contain any Test folders.

Note: Checked also for Test/Tests/test/tests

• Found only ./libraries/vendor/php-tuf/php-tuf/tests remaining
  • PHP-TUF is our forked and patched version of the original PHP-TUF client

[muhme]

Thank you @sathwikre for your contribution. Thank you @brianteeman for support. Thank you @465645, @ompatwa000-svg and @brianteeman for testing.,