-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[5.4] Menu item : add inline help button #46762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 5.4-dev
Are you sure you want to change the base?
Conversation
|
@conseilgouz, sorry ;( but I do NOT see an inline Help Button next to the ? Help button in the toolbar of Menu Items after the Patch is applied. Test environment Joomla 5.4.2 then also tested it with Joomla 5.4.3-dev (Nightly Build from last night) |
|
Thank you for telling me. |
|
I have tested this item ✅ successfully on b9f7e81 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46762. |
|
I have tested this item ✅ successfully on b9f7e81 Tested it in Light and Dark modes. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46762. |
|
Thank you both of you for the tests. Sorry I messed up first : I also tried to implement this on menus (which uses menu view), it did not work and i took the wrong file in the first version of this PR. After checking menus, it does not contain any description, so it's useless. Pascal |
|
Even if it is a small change, but it adds new functionality to that form. Therefore it has to be rebased to 6.1-dev. See also https://github.com/joomla/joomla-cms?tab=readme-ov-file#which-branch-should-my-pull-request-target . We (maintainers) will do that when it is appropriate. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46762. |
|
I have tested this item ✅ successfully on a07a938 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46762. |
|
I have tested this item ✅ successfully on a07a938 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46762. |
|
I have tested this item ✅ successfully on a07a938 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46762. |


Summary of Changes
Add inlinehelp toggle button for menu item
Testing Instructions
Edit a menu item and play with inlinehelp toggle button.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed