Skip to content

Conversation

@conseilgouz
Copy link
Contributor

@conseilgouz conseilgouz commented Jan 27, 2026

Summary of Changes

Add inlinehelp toggle button for menu item

Testing Instructions

Edit a menu item and play with inlinehelp toggle button.

Actual result BEFORE applying this Pull Request

  • no inlinehelp button
  • description shown

Expected result AFTER applying this Pull Request

  • Inlinehelp toggle button in toolbar next to help button.
  • Descriptions hidden by default

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@tecpromotion tecpromotion changed the title Menu items : add inline help button [5.4] Menu items : add inline help button Jan 27, 2026
@exlemor
Copy link

exlemor commented Jan 28, 2026

@conseilgouz, sorry ;( but I do NOT see an inline Help Button next to the ? Help button in the toolbar of Menu Items after the Patch is applied.

Test environment Joomla 5.4.2 then also tested it with Joomla 5.4.3-dev (Nightly Build from last night)

@conseilgouz conseilgouz changed the title [5.4] Menu items : add inline help button [5.4] Menu item : add inline help button Jan 28, 2026
@conseilgouz
Copy link
Contributor Author

Thank you for telling me.
It has been fixed.
Pascal

@mariantanase
Copy link

mariantanase commented Jan 28, 2026

I have tested this item ✅ successfully on b9f7e81

The desired behavior after applying the patch


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46762.

Before
buttons-before

After
buttons-after

@exlemor
Copy link

exlemor commented Jan 28, 2026

I have tested this item ✅ successfully on b9f7e81

Hello @conseilgouz, Merci, Thank you for the fix, I was now able to test it successfully! :)

Tested it in Light and Dark modes.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46762.

@conseilgouz
Copy link
Contributor Author

Thank you both of you for the tests.

Sorry I messed up first : I also tried to implement this on menus (which uses menu view), it did not work and i took the wrong file in the first version of this PR. After checking menus, it does not contain any description, so it's useless.

Pascal

@richard67 richard67 changed the base branch from 5.4-dev to 6.1-dev January 29, 2026 20:18
@richard67 richard67 requested a review from chmst as a code owner January 29, 2026 20:18
@richard67 richard67 changed the base branch from 6.1-dev to 5.4-dev January 29, 2026 20:18
@richard67
Copy link
Member

Even if it is a small change, but it adds new functionality to that form. Therefore it has to be rebased to 6.1-dev. See also https://github.com/joomla/joomla-cms?tab=readme-ov-file#which-branch-should-my-pull-request-target .

We (maintainers) will do that when it is appropriate.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46762.

@richard67 richard67 removed the Feature label Jan 29, 2026
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 29, 2026
@richard67 richard67 added Feature RMDQ ReleaseManagerDecisionQueue and removed RTC This Pull Request is Ready To Commit labels Jan 29, 2026
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 29, 2026
@imrohitkodam
Copy link

I have tested this item ✅ successfully on a07a938

Before applying patch there is no Toggle Inline Help button but after applying patch button added there in home menu


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46762.

@Vineet7875
Copy link

I have tested this item ✅ successfully on a07a938

test successfull


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46762.

@KishoriBKarale
Copy link

I have tested this item ✅ successfully on a07a938


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46762.

@richard67 richard67 changed the base branch from 5.4-dev to 6.1-dev February 1, 2026 10:09
@richard67 richard67 changed the base branch from 6.1-dev to 5.4-dev February 1, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature PR-5.4-dev RMDQ ReleaseManagerDecisionQueue RTC This Pull Request is Ready To Commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants