[6.1] Refactor SiteApplication language detection#46549
Merged
HLeithner merged 5 commits intojoomla:6.1-devfrom Jan 23, 2026
Merged
[6.1] Refactor SiteApplication language detection#46549HLeithner merged 5 commits intojoomla:6.1-devfrom
HLeithner merged 5 commits intojoomla:6.1-devfrom
Conversation
AlterBrains
reviewed
Dec 11, 2025
Contributor
|
I have tested this item ✅ successfully on 5ef954d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46549. |
Contributor
|
I have tested this item ✅ successfully on f283c35 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46549. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46549. |
laoneo
reviewed
Jan 15, 2026
HLeithner
reviewed
Jan 23, 2026
Member
|
If tests are successful, it should be automerged, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This PR improves the
initialiseApp()method inSiteApplicationby extracting the language-detection logic into a separate method. The logic remains unchanged, but the code is cleaner, reduces nesting, and is easier to maintain.Testing Instructions
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works, with cleaner, easier to maintain code
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed