Skip to content

[6.1] Refactor SiteApplication language detection#46549

Merged
HLeithner merged 5 commits intojoomla:6.1-devfrom
joomdonation:site-application-detect-language
Jan 23, 2026
Merged

[6.1] Refactor SiteApplication language detection#46549
HLeithner merged 5 commits intojoomla:6.1-devfrom
joomdonation:site-application-detect-language

Conversation

@joomdonation
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

This PR improves the initialiseApp() method in SiteApplication by extracting the language-detection logic into a separate method. The logic remains unchanged, but the code is cleaner, reduces nesting, and is easier to maintain.

Testing Instructions

  • Uses Joomla 6.1
  • Apply patch
  • Navigate to random pages from frontend of the site and make sure it is still working as before.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works, with cleaner, easier to maintain code

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomdonation joomdonation changed the title Refactor SiteApplication language detection [6.1]Refactor SiteApplication language detection Dec 8, 2025
@richard67 richard67 changed the title [6.1]Refactor SiteApplication language detection [6.1] Refactor SiteApplication language detection Dec 8, 2025
@ceford
Copy link
Contributor

ceford commented Jan 3, 2026

I have tested this item ✅ successfully on 5ef954d

Tested on a a 6.1 site with Testing Data and two languages installed. Randomly selected menu items all worked as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46549.

@tecpromotion
Copy link
Contributor

I have tested this item ✅ successfully on f283c35

Tested with de-de and en-gb.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46549.

@tecpromotion
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46549.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 9, 2026
@tecpromotion tecpromotion requested a review from HLeithner January 9, 2026 15:49
@HLeithner HLeithner enabled auto-merge (squash) January 23, 2026 15:17
@HLeithner
Copy link
Member

If tests are successful, it should be automerged, thanks.

@HLeithner HLeithner merged commit a6b594b into joomla:6.1-dev Jan 23, 2026
51 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 23, 2026
@joomdonation joomdonation deleted the site-application-detect-language branch February 1, 2026 09:06
@tecpromotion tecpromotion added this to the Joomla! 6.1.0 milestone Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants