fix: prune deleted remotes during git import#9175
Open
cormacrelf wants to merge 1 commit intomainfrom
Open
Conversation
cormacrelf
force-pushed
the
prune-deleted-remotes
branch
3 times, most recently
from
695c376 to
bb4b84e
Compare
We had the ability to import externally added git remotes (git remote add xxx ...) but not the ability to delete them from our view of the repo when they were removed from the git config. This prunes them in much the same way.
cormacrelf
force-pushed
the
prune-deleted-remotes
branch
from
bb4b84e to
ff06f0f
Compare
Contributor
|
I think it's better to add a command (or flag) to remove remotes after the fact. #7143 Deleting an empty remote view should be harmless, but it's odd that absent tracking can also be discarded implicitly. |
Contributor
|
if you read our contributing guidelines you should know that we don't allow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I only noticed this issue when I accidentally used
git remote remove xxx, a typo where thejjgot lost. I kept trying to track branches and then finding myself unable to push them because JJ kept creating remote-tracking branches for@xxxas well, andjj git remote listwas not showing xxx. I guess it's a separate bug thatjj git remote listdoes not list jj's actual list of remote views... but at least we can prune them.Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)how it works, how it's organized), including any code drafted by an LLM.
an eye towards deleting anything that is irrelevant, clarifying anything
that is confusing, and adding details that are relevant. This includes,
for example, commit descriptions, PR descriptions, and code comments.