copier fails silently when source field implements valuer interface#141
Open
thetarby wants to merge 1 commit intojinzhu:masterfrom
Open
copier fails silently when source field implements valuer interface#141thetarby wants to merge 1 commit intojinzhu:masterfrom
thetarby wants to merge 1 commit intojinzhu:masterfrom
Conversation
Author
|
Does anybody have any thoughts on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Think that I have a CompanyEntity struct which is used in database layer and a CompanyModel in business layer with same fields. In CompanyEntity I have a struct or slice field which is saved as json text in the database by implementing valuer/scanner. With this setup copier fails to copy the field implementing valuer from entity to model because what Value() method returns is not assignable to destination field type which is a struct.
This is a test with above mentioned setup. I expect copier to pass this test but current version fails to do so. Pr includes a simple solution.