fix: prevent reinitialize error at getFlags#131
Open
ag9920 wants to merge 1 commit intojinzhu:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to fix a variable shadowing problem and format the copier_test.go file.
The
copierfunction declares a returned variable err, which saves the trouble of initializing inside the body.func copier(toValue interface{}, fromValue interface{}, opt Option) (err error)But then the err variable would be shadowed by the returned error of getFlags function ( line 235), which makes it impossible to return the error message from
checkBitFlags(flgs.BitFlags)function call (line 370).From a caller's perspective, even if a "must,nopanic" tag was set, no error will be returned. This PR would fix the problem and provide the corresponding test case in copier_tags_test.go (TestCopyTagMustNoPanic).