fix: copy websocket.AcceptOptions to avoid CompressionMode leak #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
serveWS, when a Safari user-agent is detected, the code mutatese.acceptOptions.CompressionModedirectly to disable compression. Sincee.acceptOptionsis shared across all requests, this mutation leaks to subsequent non-Safari connections (they also get compression disabled). There is also a data race: concurrent WebSocket upgrades read and write the same struct field without synchronization.I replaced the shared mutation with a per-request local copy. Non-Safari requests pass
e.acceptOptionsas-is (read-only). Safari requests shallow-copy the struct into a local variable and setCompressionDisabledon the copy. The sharede.acceptOptionsis never modified after initialization.