Open
Conversation
This reverts commit 6fcf850.
- Restore Deleted != 1 filter on Android Instances query to prevent soft-deleted events from reappearing - Remove aggressive EventStore.Reset() from iOS single-item lookups (GetPlatformCalendar, GetPlatformEvent) while keeping it for listing methods (GetCalendars, GetEvents) - Document recurring event expansion behavior in ICalendarStore XML docs - Remove unused referenceOffset parameter from ToFilterTimestampMillis Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Use CalendarStore.ToFilterTimestampMillis() in Android GetEvents so the tested helper is actually called from production code - Cache attendees and reminders by EventId in ToEventsFromInstances to avoid redundant N+1 queries for recurring event occurrences Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Extract BuildInstancesSelection() for testable SQL selection logic - Extract generic GetOrAdd() cache helper, replacing dedicated methods - Add 6 new tests: selection string construction (4) and cache behavior (2) - Total test count: 18 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reapplies the stale event data fix that was in #77 (reverted from v4.1.0 release).
Fixes:
Tests:
Fixes #51