feat: add redirectIfNotAuthenticatedMiddleware to enforce authentication before accessing app routes#1674
Open
feat: add redirectIfNotAuthenticatedMiddleware to enforce authentication before accessing app routes#1674
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an authentication gate for the SPA entry route so unauthenticated users are redirected to login instead of being served the /app shell.
Changes:
- Introduces
redirectIfNotAuthenticatedMiddlewareto redirect missing/placeholder sessions to/auth/login. - Wires the new middleware into the
/appmiddleware chain in the API server.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/api/src/main.ts | Adds the new middleware into the /app route middleware stack. |
| apps/api/src/app/routes/route.middleware.ts | Implements redirectIfNotAuthenticatedMiddleware for session-based gating. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ion before accessing app routes We were previously relying on API calls to redirect the user on app load, but if the user does not have a session then there is no reason to server the application
paustint
force-pushed
the
fix/protected-assets-session-check
branch
from
6734aff to
e6db530
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were previously relying on API calls to redirect the user on app load, but if the user does not have a session then there is no reason to server the application