fix: use useRef for Host queue to improve stability#20
Open
teaualune wants to merge 1 commit intojeremybarbet:masterfrom
Open
fix: use useRef for Host queue to improve stability#20teaualune wants to merge 1 commit intojeremybarbet:masterfrom
teaualune wants to merge 1 commit intojeremybarbet:masterfrom
Conversation
|
For anyone looking for a patch: https://gist.github.com/lucasjohnston/5bf626fae923009ae1cf5a5db894842f In the process of debugging our freezing issues I came across this thread and realised modals aren't unmounting properly as OP described. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using this library to build "overlay" widgets in our RN project, we discovered that some
Portals did not unmount correctly.For instance, our react-navigation based project has
ScreenAcontainingOverlayA, which are implemented withPortal. WhenScreenAis popped, we found that sometimesOverlayAis not unmounted, out of our expectation.After some digging, it seems that the
queuearray inHostcomponent might be one of the problem: sinceHostis a functional component,queueis re-initialized each timeHostre-renders. According to the original implementation,queueis a class member, so it should become aRefObjectafter converting to functional component.I utilized
patch-packageto create a hotfix for my project and the behavior becomes expected, so I created this PR to address the problem. This PR rewritesqueueinto aRefObjectwithuseRefas well as extracts type definition ofqueueintoIPortalAction.