[JENKINS-65032] Add option to include merge commits in changelogs#1214
Open
railsharipov wants to merge 11 commits intojenkinsci:masterfrom
Open
[JENKINS-65032] Add option to include merge commits in changelogs#1214railsharipov wants to merge 11 commits intojenkinsci:masterfrom
railsharipov wants to merge 11 commits intojenkinsci:masterfrom
Conversation
|
Note that this was requested before but the PR was not merged. I would also like to include merge commits but my preference would be to simply use git log instead of git whatchanged for CliGitAPIImpl (no hablo how to implement for JGit). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing done
Added features
Required changes
--format=raw.rawformat the date format was changed to default (unix time).In the past, changelog format for CliGit implementation was changed to custom format because of the
git-plugindate parsing issue (https://issues.jenkins.io/browse/JENKINS-27097). Since thengit-plugindate parsing has been updated: https://github.com/jenkinsci/git-plugin/blob/master/src/main/java/hudson/plugins/git/GitChangeSet.java#L282-L300Currently following custom changelog format is used:
Unfortunately, the above custom format is not equivalent to git-log
rawformat since all parent commits are placed on a single line:Although expected output is:
Existing JGit implementation places each parent commit on a separate line so there is inconsistency between CliGit and JGit implementations. Because of that additional changes were required.
Submitter checklist