Refactor/replace httpretty with responses#577
Merged
jdepoix merged 2 commits intojdepoix:masterfrom Mar 9, 2026
Merged
Conversation
Pull Request Test Coverage Report for Build 22795606950Details
💛 - Coveralls |
Owner
|
Thank you for your contribution @kaya70875 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the test suite's HTTP mocking library from httpretty (which is no langer actively maintained) to responses to provide better stability and integration with the requests library. The existing
unittest.TestCasearchitecture was preserved to keep the refactor focused and the diff clean.Key Changes
Mock Lifecycle: Replaced
httpretty.activatewithresponses.start()andself.addCleanup(responses.stop)insidesetUp()to ensure base mocks persist correctly across the test lifecycle.State Overrides: Used
responses.replace()and chainedresponses.add()calls to handle test-specific mock overrides and sequential retry logic (e.g., for proxy and consent cookie tests).Content-Type Fixes: Explicitly added
content_type="application/json"to innertube API mocks. responses defaults to text/plain, which was preventing the error handler from parsing JSON and causing false-positiveVideoUnplayableexceptions.