Merged
Conversation
The unit test only tested for the '|' literal indicator. But in some cases it should have been '|-'. If a string does not end with an '\n' it has to use '|-' to indicate that the trailing new line is not part of the string. Additionally, I also added a explicit test for '|+'.
log: fix literal string outputs 'chomping indicator' if required
SGSSGene
force-pushed
the
fix/literal_output
branch
from
40b3e9a to
939e231
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1238
This fixes the unit tests for expecting '|-' in cases where a string literal does not end on a new line. (Unit tests now fail)
It adds a unit test which also tests for '|+' (This tests now also fails)
Finally, added the missing functionality to make the unit tests pass again.