Skip to content

Hash-pin github actions versions#2369

Merged
webknjaz merged 1 commit intojazzband:mainfrom
sirosen:pin-github-actions
Apr 15, 2026
Merged

Hash-pin github actions versions#2369
webknjaz merged 1 commit intojazzband:mainfrom
sirosen:pin-github-actions

Conversation

@sirosen
Copy link
Copy Markdown
Member

@sirosen sirosen commented Apr 3, 2026

Applied by gha-update (with failing items with no tags commented out).

Contributor checklist
  • Included tests for the changes.
  • A change note is created in changelog.d/ (see changelog.d/README.md
    for instructions) or the PR text says "no changelog needed".
Maintainer checklist
  • If no changelog is needed, apply the bot:chronographer:skip label.
  • Assign the PR to an existing or new milestone for the target version
    (following Semantic Versioning).

@sirosen sirosen added this to the 7.6.0 milestone Apr 3, 2026
@sirosen sirosen requested a review from a team as a code owner April 3, 2026 23:30
Comment thread .github/workflows/ci.yml Dismissed
Comment thread .github/workflows/ci.yml Dismissed
Comment thread .github/workflows/ci.yml Fixed
Comment thread .github/workflows/ci.yml Fixed
Comment thread .github/workflows/reusable-qa.yml Fixed
@sirosen
Copy link
Copy Markdown
Member Author

sirosen commented Apr 3, 2026

I'm dismissing the code-scanning alerts.

At first, I couldn't understand why these (known!) issues were being marked as part of this PR, but I got a pointer from @ichard26 (thanks again!) to this:
https://docs.github.com/en/code-security/reference/code-scanning/sarif-files/sarif-support-for-code-scanning#source-file-locations

So it looks like I'm just editing too close to where the SARIF findings are demarcated.

Obviously I want to fix all of these, but one thing at a time.

Comment thread .github/workflows/ci.yml Outdated
steps:
- name: Switch to using Python 3.14 by default
uses: actions/setup-python@v6
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use two-space indents?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean, invent the list item, starting at the -? I would like to. I'm slowly trying to apply that style to every YAML file I interact with.

But I don't think we want it in this PR.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant

Suggested change
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for the list items, I actually prefer no additional indentation in that place. This is the style I'm using everywhere: https://github.com/cherrypy/cheroot/blob/2ffb0baf8aa480da9da8d522b3fd7eab271f6dba/.yamllint

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, gotcha, two spaces for the comments. Yeah, I'll amend.

As for the indent-sequences: false rule, we should probably add yamllint here. I don't feel very strongly about it, but I'm likely to use the other style if it's not enforced.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in the course of a rebase.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for the indent-sequences: false rule, we should probably add yamllint here.

Yes, and a copy of that config. It just so happened that I kept postponing it, focusing on other stuff. But feel free to sync both yamllint config + pre-commit config from Cheroot in a standalone patch.

Applied by `gha-update` (with failing items with no tags commented out).
@sirosen sirosen force-pushed the pin-github-actions branch from 6a3ede2 to 87a1a1f Compare April 14, 2026 18:16
Comment thread .github/workflows/ci.yml Dismissed
Comment thread .github/workflows/ci.yml Dismissed
Comment thread .github/workflows/reusable-qa.yml Dismissed
@webknjaz webknjaz added this pull request to the merge queue Apr 15, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 15, 2026
@webknjaz webknjaz added this pull request to the merge queue Apr 15, 2026
@webknjaz
Copy link
Copy Markdown
Member

A few PyPy jobs seem to need another minute to be able to complete: https://github.com/jazzband/pip-tools/actions/runs/24464328233

@sirosen
Copy link
Copy Markdown
Member Author

sirosen commented Apr 15, 2026

I'd like to give them a much more generous margin, if they're running into the limits, since CI runtimes aren't very stable. I'll prep a PR right away -- I've got a few minutes in the middle of my day right now. 😁

@sirosen
Copy link
Copy Markdown
Member Author

sirosen commented Apr 15, 2026

PR for a more generous timeout visible here.

Merged via the queue into jazzband:main with commit 8b72f77 Apr 15, 2026
75 checks passed
@webknjaz
Copy link
Copy Markdown
Member

Alright.. This got in on the retry. We'll get higher timeouts merged in next thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants